From 704402513b18fec9a1597b538d00ab8a9d1219dd Mon Sep 17 00:00:00 2001 From: ianswett Date: Tue, 17 Sep 2019 18:59:38 -0400 Subject: [PATCH 1/2] Send after receiving an ACK Fixes #2604 --- draft-ietf-quic-recovery.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 8358c56ae8..cac21e8b39 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -1007,8 +1007,8 @@ OnAckReceived(ack, pn_space): largest_acked_packet[pn_space] = max(largest_acked_packet[pn_space], ack.largest_acked) - // Nothing to do if there are no newly acked packets. newly_acked_packets = DetermineNewlyAckedPackets(ack, pn_space) + // Nothing to do if there are no newly acked packets. if (newly_acked_packets.empty()): return @@ -1031,9 +1031,8 @@ OnAckReceived(ack, pn_space): OnPacketAcked(acked_packet.packet_number, pn_space) DetectLostPackets(pn_space) - + SendPacketsAsCongestionControllerAllows() pto_count = 0 - SetLossDetectionTimer() From a6370e8431ea1498cb08e9a6383cb908432ece81 Mon Sep 17 00:00:00 2001 From: ianswett Date: Tue, 19 Nov 2019 00:55:24 -0500 Subject: [PATCH 2/2] Send up to IW --- draft-ietf-quic-recovery.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index cac21e8b39..c099949248 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -1031,7 +1031,9 @@ OnAckReceived(ack, pn_space): OnPacketAcked(acked_packet.packet_number, pn_space) DetectLostPackets(pn_space) - SendPacketsAsCongestionControllerAllows() + // Immediately attempt to send, but never more than the + // initial window in a single burst. + SendUpToIWPacketsAsCongestionControllerAllows() pto_count = 0 SetLossDetectionTimer()