From 568febf40a21f538abe126d8598e5b45ce21ec31 Mon Sep 17 00:00:00 2001 From: ianswett Date: Mon, 28 Oct 2019 10:11:17 -0400 Subject: [PATCH 1/3] MUST limit bursts to the initial congestion window From discussion on #3106 https://github.com/quicwg/base-drafts/pull/3106#discussion_r338921935 --- draft-ietf-quic-recovery.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 2d585a94da..2f25dfd655 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -744,9 +744,9 @@ their delivery to the peer. Sending multiple packets into the network without any delay between them creates a packet burst that might cause short-term congestion and losses. -Implementations MUST either use pacing or limit such bursts to the minimum -of 10 * kMaxDatagramSize and max(2* kMaxDatagramSize, 14720)), the same -as the recommended initial congestion window. +Implementations MUST either use pacing or limit such bursts to the initial +congestion window, which in this document is recommended to be the min of +10 * kMaxDatagramSize and max(2* kMaxDatagramSize, 14720)). As an example of a well-known and publicly available implementation of a flow pacer, implementers are referred to the Fair Queue packet scheduler (fq qdisc) From bc27ab1719ed440795fcd086b93a7bb0373f0dd7 Mon Sep 17 00:00:00 2001 From: ianswett Date: Mon, 28 Oct 2019 10:13:13 -0400 Subject: [PATCH 2/3] Update draft-ietf-quic-recovery.md --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 2f25dfd655..eae14e79dd 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -745,7 +745,7 @@ their delivery to the peer. Sending multiple packets into the network without any delay between them creates a packet burst that might cause short-term congestion and losses. Implementations MUST either use pacing or limit such bursts to the initial -congestion window, which in this document is recommended to be the min of +congestion window, which is recommended to be the min of 10 * kMaxDatagramSize and max(2* kMaxDatagramSize, 14720)). As an example of a well-known and publicly available implementation of a flow From 7b268f0e6818ff0ceadeb6642ef461c0b8890a79 Mon Sep 17 00:00:00 2001 From: ianswett Date: Tue, 29 Oct 2019 07:08:47 -0400 Subject: [PATCH 3/3] Update draft-ietf-quic-recovery.md Co-Authored-By: Martin Thomson --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index eae14e79dd..ad96b97d6f 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -745,7 +745,7 @@ their delivery to the peer. Sending multiple packets into the network without any delay between them creates a packet burst that might cause short-term congestion and losses. Implementations MUST either use pacing or limit such bursts to the initial -congestion window, which is recommended to be the min of +congestion window, which is recommended to be the minimum of 10 * kMaxDatagramSize and max(2* kMaxDatagramSize, 14720)). As an example of a well-known and publicly available implementation of a flow