From e67136d36940dc1dfc21f3d67cb80c75ac55a71d Mon Sep 17 00:00:00 2001 From: ianswett Date: Wed, 30 Oct 2019 09:37:20 -0400 Subject: [PATCH 1/4] Retry MUST NOT -> cannot be treated as an acknowledgement I didn't notice this last commit in @martinthomson PR, but I think the older text is more correct. I added a bit more detail about why it cannot be treated as an acknowledgement. --- draft-ietf-quic-recovery.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index d27b4c665a..34cabc6c79 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -575,8 +575,9 @@ dictated by packet and time threshold mechanisms; see {{ack-loss-detection}}. A Retry packet causes a client to send another Initial packet, effectively restarting the connection process. A Retry packet indicates that the Initial -was received, but not processed. A Retry packet MUST NOT be treated as an -acknowledgment. +was received, but not processed. A Retry packet cannot be treated as an +acknowledgment, because it does not specify the packet number of the received +packet. Clients that receive a Retry packet reset congestion control and loss recovery state, including resetting any pending timers. Other connection state, in From 79238880c2813ba5eaf0170b971d8d782508c830 Mon Sep 17 00:00:00 2001 From: ianswett Date: Wed, 30 Oct 2019 19:31:15 -0400 Subject: [PATCH 2/4] Martin's reason --- draft-ietf-quic-recovery.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 34cabc6c79..a5b2012a62 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -576,8 +576,8 @@ dictated by packet and time threshold mechanisms; see {{ack-loss-detection}}. A Retry packet causes a client to send another Initial packet, effectively restarting the connection process. A Retry packet indicates that the Initial was received, but not processed. A Retry packet cannot be treated as an -acknowledgment, because it does not specify the packet number of the received -packet. +acknowledgment, because it does not indicate a packet was processed or +specify the packet number of the packet. Clients that receive a Retry packet reset congestion control and loss recovery state, including resetting any pending timers. Other connection state, in From b44efce9af51bd2f9852ec385c9a79ac0d7fe953 Mon Sep 17 00:00:00 2001 From: ianswett Date: Wed, 30 Oct 2019 19:31:49 -0400 Subject: [PATCH 3/4] Update draft-ietf-quic-recovery.md --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index a5b2012a62..12092a250b 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -577,7 +577,7 @@ A Retry packet causes a client to send another Initial packet, effectively restarting the connection process. A Retry packet indicates that the Initial was received, but not processed. A Retry packet cannot be treated as an acknowledgment, because it does not indicate a packet was processed or -specify the packet number of the packet. +specify the packet number. Clients that receive a Retry packet reset congestion control and loss recovery state, including resetting any pending timers. Other connection state, in From 0e759f03ca894a855797e1c58e4afde639f787a4 Mon Sep 17 00:00:00 2001 From: ianswett Date: Wed, 30 Oct 2019 20:43:23 -0400 Subject: [PATCH 4/4] Update draft-ietf-quic-recovery.md Co-Authored-By: Martin Thomson --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 12092a250b..dafbf7d33f 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -576,7 +576,7 @@ dictated by packet and time threshold mechanisms; see {{ack-loss-detection}}. A Retry packet causes a client to send another Initial packet, effectively restarting the connection process. A Retry packet indicates that the Initial was received, but not processed. A Retry packet cannot be treated as an -acknowledgment, because it does not indicate a packet was processed or +acknowledgment, because it does not indicate that a packet was processed or specify the packet number. Clients that receive a Retry packet reset congestion control and loss recovery