Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use no_application_protocol more #3228

Merged
merged 3 commits into from Dec 3, 2019
Merged

Use no_application_protocol more #3228

merged 3 commits into from Dec 3, 2019

Conversation

@martinthomson
Copy link
Member

martinthomson commented Nov 12, 2019

The old text used the non-specific "abort" here, but we can point to the right error code.

Closes #2500.

The old text used the non-specific "abort" here, but we can use the
right error code.

Closes #2500.
combination of application protocol and QUIC version, it MUST abort the
connection. A client MUST abort a connection if the server picks an application
protocol incompatible with the protocol version being used.
version that the client has selected. If the server MUST treat the inability to

This comment has been minimized.

Copy link
@marten-seemann

marten-seemann Nov 12, 2019

Contributor

Did you mean to remove the "If"?

@kazuho
kazuho approved these changes Nov 14, 2019
Copy link
Member

kazuho left a comment

LGTM modulo the preference below.

negotiated with a no_application_protocol TLS alert (QUIC error code 0x178, see
{{tls-errors}}). While {{!ALPN}} only specifies that servers use this alert,
QUIC clients MUST also use it to terminate a connection when ALPN negotiation
fails.

An application-layer protocol MAY restrict the QUIC versions that it can operate

This comment has been minimized.

Copy link
@kazuho

kazuho Nov 14, 2019

Member

s/application-layer protocol/application protocol/?

The issue is in the current text, but it’s confusing to use different term here.

@martinthomson martinthomson merged commit 5470410 into master Dec 3, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@martinthomson martinthomson deleted the abort branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.