New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A pacing algorithm #3630
Merged
Merged
A pacing algorithm #3630
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f001162
A pacing algorithm
martinthomson 561df07
Forgot to include smoothed_rtt in the description
martinthomson a4b888e
Reword rationale somewhat
martinthomson b776f4d
Using suggestions to edit
martinthomson 37eaf7e
Add a blank line
martinthomson 7579140
Shorter figure line
martinthomson 7ddcd1d
Trying to thread the needle
martinthomson 954f037
Fix
martinthomson dbc8ffc
under-utilization
martinthomson 819f4d0
Some editorial rearrangement
martinthomson 42a1dd8
Some improvements from Ian
martinthomson b0a1b1c
ack-clocking
martinthomson a320b54
Reword ack-clocking again
martinthomson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all too much prescription. I suggest you move this up above the previous paragraph, and lead into the burst paragraphs like so:
"Endpoints can implement pacing as they choose. A perfectly paced sender spreads bytes exactly evenly over time. For a window-based congestion controller, such as the one in this document, that rate can be computed by averaging the congestion window over the round-trip time. More precisely,
pacing rate = N * congestion_window / smoothed_rtt
, where using a small N (for example, 1.25) protects the sender from short-term variations in round-trip time or from scheduler delays.Further practical considerations, such as packetization, scheduling delays, and computational efficiency, can cause a sender to deviate from this rate over time periods that are much shorter than a round-trip time. Sending multiple packets into the network without any delay ..."