Move MUST not send bursts up in the pacing section #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-on from #3630
martinthomson
approved these changes
May 18, 2020
Comment on lines
-883
to
-885
| controller. For example, a pacer might distribute the congestion window over | ||
| the smoothed RTT when used with a window-based controller, or a pacer might use | ||
| the rate estimate of a rate-based controller. |
There was a problem hiding this comment.
I'm OK with leaving this out, but I'm interested in why you did.
There was a problem hiding this comment.
I thought it was redundant to the text you added below.
|
I'm not a fan of this change -- I think there's value in having that text below where we talk about how bursts can occur. That said, I don't feel strongly about it, so I'm not going to fight for it. |
martinthomson
added
-recovery
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to have MUSTs towards the top of sections when possible so they're not missed.
This is a follow-on from #3630