Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error for frames in the wrong packet #3859

Merged
merged 1 commit into from Aug 4, 2020
Merged

Error for frames in the wrong packet #3859

merged 1 commit into from Aug 4, 2020

Conversation

martinthomson
Copy link
Member

Closes #3851.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jul 8, 2020
marten-seemann
marten-seemann reviewed Jul 8, 2020
View reviewed changes
draft-ietf-quic-transport.md
that all frames can appear in 1-RTT packets.
that all frames can appear in 1-RTT packets. An endpoint MUST treat receipt of
a frame in a packet type that is not permitted as a connection error of type
PROTOCOL_VIOLATION.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would FRAME_ENCODING_ERROR be ok too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting question. It's not something that can be determined without context, so I would lean toward "no".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what your definition of "context" is. If it is "the bytes that this frame is composed of", then no. If you include the encryption level you received those bytes with, then "yes". You might want to do that, because the encryption level is not connection-level state.

@janaiyengar janaiyengar merged commit 5d25596 into master Aug 4, 2020
@janaiyengar janaiyengar deleted the naughty-frame branch August 4, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann left review comments

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frames of impermissible type
4 participants
@martinthomson @marten-seemann @ianswett @janaiyengar