From 5e3fd9e88b3de174ec858e7040056c5759d1730e Mon Sep 17 00:00:00 2001 From: ianswett Date: Thu, 15 Oct 2020 10:05:15 -0400 Subject: [PATCH 1/5] Excess ack_delay could be non-compiance Fixes #4191 --- draft-ietf-quic-recovery.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index bde35e40ab..a008dd18ec 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -374,7 +374,8 @@ min_rtt. After the handshake is confirmed, any acknowledgement delays reported by the peer that are greater than the peer's max_ack_delay are attributed to unintentional but potentially repeating delays, such as scheduler latency at the -peer or loss of previous acknowledgements. Therefore, these extra delays are +peer or loss of previous acknowledgements. These delays could also be due to +a non-compliant implementaton. Therefore, these extra delays are considered effectively part of path delay and incorporated into the RTT estimate. From 8d9643994894e2d6f505cab2138ecbb214cda7e2 Mon Sep 17 00:00:00 2001 From: ianswett Date: Thu, 15 Oct 2020 10:06:38 -0400 Subject: [PATCH 2/5] Update draft-ietf-quic-recovery.md --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index a008dd18ec..34dd6e42eb 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -353,7 +353,7 @@ samples, and rttvar is the variation in the RTT samples, estimated using a mean variation. The calculation of smoothed_rtt uses RTT samples after adjusting them for -acknowledgement delays. These delays are computed using the ACK Delay field of +acknowledgement delays. Excess delays are computed using the ACK Delay field of the ACK frame as described in Section 19.3 of {{QUIC-TRANSPORT}}. The peer might report acknowledgement delays that are larger than the peer's From 93e1c550f4c4477790928204a1838421e8ac96ed Mon Sep 17 00:00:00 2001 From: ianswett Date: Thu, 15 Oct 2020 10:07:04 -0400 Subject: [PATCH 3/5] Update draft-ietf-quic-recovery.md --- draft-ietf-quic-recovery.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 34dd6e42eb..6fdc29884e 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -353,7 +353,7 @@ samples, and rttvar is the variation in the RTT samples, estimated using a mean variation. The calculation of smoothed_rtt uses RTT samples after adjusting them for -acknowledgement delays. Excess delays are computed using the ACK Delay field of +acknowledgement delays. These delays are computed using the ACK Delay field of the ACK frame as described in Section 19.3 of {{QUIC-TRANSPORT}}. The peer might report acknowledgement delays that are larger than the peer's @@ -374,7 +374,7 @@ min_rtt. After the handshake is confirmed, any acknowledgement delays reported by the peer that are greater than the peer's max_ack_delay are attributed to unintentional but potentially repeating delays, such as scheduler latency at the -peer or loss of previous acknowledgements. These delays could also be due to +peer or loss of previous acknowledgements. Excess delays could also be due to a non-compliant implementaton. Therefore, these extra delays are considered effectively part of path delay and incorporated into the RTT estimate. From e1a08aa24ae467039183842d0c71013ef2e369b6 Mon Sep 17 00:00:00 2001 From: ianswett Date: Thu, 15 Oct 2020 16:26:13 -0400 Subject: [PATCH 4/5] Update draft-ietf-quic-recovery.md Co-authored-by: Jana Iyengar --- draft-ietf-quic-recovery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 6fdc29884e..ab00569c01 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -375,7 +375,7 @@ After the handshake is confirmed, any acknowledgement delays reported by the peer that are greater than the peer's max_ack_delay are attributed to unintentional but potentially repeating delays, such as scheduler latency at the peer or loss of previous acknowledgements. Excess delays could also be due to -a non-compliant implementaton. Therefore, these extra delays are +a non-compliant receiver. Therefore, these extra delays are considered effectively part of path delay and incorporated into the RTT estimate. From e906bb629f1bbaaef9c11f72bc5405c258efc7c7 Mon Sep 17 00:00:00 2001 From: ianswett Date: Thu, 15 Oct 2020 16:32:34 -0400 Subject: [PATCH 5/5] Reflow --- draft-ietf-quic-recovery.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index ab00569c01..01d979801c 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -375,9 +375,8 @@ After the handshake is confirmed, any acknowledgement delays reported by the peer that are greater than the peer's max_ack_delay are attributed to unintentional but potentially repeating delays, such as scheduler latency at the peer or loss of previous acknowledgements. Excess delays could also be due to -a non-compliant receiver. Therefore, these extra delays are -considered effectively part of path delay and incorporated into the RTT -estimate. +a non-compliant receiver. Therefore, these extra delays are considered +effectively part of path delay and incorporated into the RTT estimate. Therefore, when adjusting an RTT sample using peer-reported acknowledgement delays, an endpoint: