Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak framing of frames table #4310

Merged
merged 3 commits into from Oct 30, 2020
Merged

Tweak framing of frames table #4310

merged 3 commits into from Oct 30, 2020

Conversation

martinthomson
Copy link
Member

Less detail above, but a pointer to what follows.

Closes #4299.

Less detail above, but a pointer to what follows.

Closes #4299.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Oct 29, 2020
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Bishop <mbishop@evequefou.be>
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but LGTM

Comment on lines 3424 to 3425
The frame types defined in this specification are listed in {{frame-types}}.
The Frame Type in ACK, STREAM, MAX_STREAMS, STREAMS_BLOCKED, and
CONNECTION_CLOSE frames is used to carry other frame-specific flags. For all
other frames, the Frame Type field simply identifies the frame. These
frames are explained in more detail in {{frame-formats}}.
{{frame-types}} includes some summary information that is explained below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"{{frame-types}} lists and summarizes information about each frame type that is
defined in this specification. The summarized information in {{frame-types}} is
described after the table."

@janaiyengar janaiyengar merged commit d56cd1f into master Oct 30, 2020
@janaiyengar janaiyengar deleted the issue4299 branch October 30, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frame Types notation
3 participants