From ac4e79bc704b892db4531095ab39ab8edf2085b5 Mon Sep 17 00:00:00 2001 From: Martin Thomson Date: Thu, 29 Oct 2020 15:24:08 +1100 Subject: [PATCH 1/3] Tweak framing of frames table Less detail above, but a pointer to what follows. Closes #4299. --- draft-ietf-quic-transport.md | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/draft-ietf-quic-transport.md b/draft-ietf-quic-transport.md index b242445ee7..980d62fb2a 100644 --- a/draft-ietf-quic-transport.md +++ b/draft-ietf-quic-transport.md @@ -3422,10 +3422,7 @@ Frame { {: #frame-layout title="Generic Frame Layout"} The frame types defined in this specification are listed in {{frame-types}}. -The Frame Type in ACK, STREAM, MAX_STREAMS, STREAMS_BLOCKED, and -CONNECTION_CLOSE frames is used to carry other frame-specific flags. For all -other frames, the Frame Type field simply identifies the frame. These -frames are explained in more detail in {{frame-formats}}. +{{frame-types}} includes some summary information that is explained below. | Type Value | Frame Type Name | Definition | Pkts | Spec | |:------------|:---------------------|:-------------------------------|------|------| @@ -3451,6 +3448,14 @@ frames are explained in more detail in {{frame-formats}}. | 0x1e | HANDSHAKE_DONE | {{frame-handshake-done}} | ___1 | | {: #frame-types title="Frame Types"} +The format and semantics of each frame type is explained in more detail in +{{frame-formats}}. The remainder of this section provides a summary of +important and general information. + +The Frame Type in ACK, STREAM, MAX_STREAMS, STREAMS_BLOCKED, and +CONNECTION_CLOSE frames is used to carry other frame-specific flags. For all +other frames, the Frame Type field simply identifies the frame. + The "Pkts" column in {{frame-types}} lists the types of packets that each frame type could appear in, indicated by the following characters: @@ -3506,9 +3511,8 @@ registry; see {{iana-frames}}. An endpoint MUST treat the receipt of a frame of unknown type as a connection error of type FRAME_ENCODING_ERROR. -All QUIC frames are idempotent in this version of QUIC. That is, a valid -frame does not cause undesirable side effects or errors when received more -than once. +All frames are idempotent in this version of QUIC. That is, a valid frame does +not cause undesirable side effects or errors when received more than once. The Frame Type field uses a variable-length integer encoding (see {{integer-encoding}}) with one exception. To ensure simple and efficient From e62d221d9bd9e41e7462e4929d3b42510a0efe26 Mon Sep 17 00:00:00 2001 From: Martin Thomson Date: Fri, 30 Oct 2020 10:33:41 +1100 Subject: [PATCH 2/3] is/are potato/tomato Co-authored-by: Mike Bishop --- draft-ietf-quic-transport.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-transport.md b/draft-ietf-quic-transport.md index 980d62fb2a..d9f7d18d4c 100644 --- a/draft-ietf-quic-transport.md +++ b/draft-ietf-quic-transport.md @@ -3448,7 +3448,7 @@ The frame types defined in this specification are listed in {{frame-types}}. | 0x1e | HANDSHAKE_DONE | {{frame-handshake-done}} | ___1 | | {: #frame-types title="Frame Types"} -The format and semantics of each frame type is explained in more detail in +The format and semantics of each frame type are explained in more detail in {{frame-formats}}. The remainder of this section provides a summary of important and general information. From 02c37e7dcac332a1753a77a3c9b5626def6e3705 Mon Sep 17 00:00:00 2001 From: Martin Thomson Date: Fri, 30 Oct 2020 11:03:45 +1100 Subject: [PATCH 3/3] Tweaked suggestion --- draft-ietf-quic-transport.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/draft-ietf-quic-transport.md b/draft-ietf-quic-transport.md index d9f7d18d4c..cde44b6804 100644 --- a/draft-ietf-quic-transport.md +++ b/draft-ietf-quic-transport.md @@ -3421,8 +3421,9 @@ Frame { ~~~ {: #frame-layout title="Generic Frame Layout"} -The frame types defined in this specification are listed in {{frame-types}}. -{{frame-types}} includes some summary information that is explained below. +{{frame-types}} lists and summarizes information about each frame type that is +defined in this specification. A description of this summary is included after +the table. | Type Value | Frame Type Name | Definition | Pkts | Spec | |:------------|:---------------------|:-------------------------------|------|------|