From 9f936a8a347926523c52ca52b68e62e60b9235b9 Mon Sep 17 00:00:00 2001 From: Alan Frindell Date: Tue, 11 May 2021 15:32:46 -0700 Subject: [PATCH] RFC Editor edits for recovery Appendix B --- rfc9002.md | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/rfc9002.md b/rfc9002.md index 900febedcd..18d4e523b4 100644 --- a/rfc9002.md +++ b/rfc9002.md @@ -1662,7 +1662,7 @@ in {{congestion-control}}. The pseudocode segments in this section are licensed as Code Components; see the copyright notice. -## Constants of interest {#cc-consts-of-interest} +## Constants of Interest {#cc-consts-of-interest} Constants used in congestion control are based on a combination of RFCs, papers, and common practice. @@ -1675,20 +1675,20 @@ kMinimumWindow: kLossReductionFactor: : Scaling factor applied to reduce the congestion window when a new loss event - is detected. {{congestion-control}} recommends a value is 0.5. + is detected. {{congestion-control}} recommends a value of 0.5. kPersistentCongestionThreshold: : Period of time for persistent congestion to be established, specified as a PTO multiplier. {{persistent-congestion}} recommends a value of 3. -## Variables of interest {#vars-of-interest} +## Variables of Interest {#vars-of-interest} Variables required to implement the congestion control mechanisms are described in this section. max_datagram_size: -: The sender's current maximum payload size. Does not include UDP or IP +: The sender's current maximum payload size. This does not include UDP or IP overhead. The max datagram size is used for congestion window computations. An endpoint sets the value of this variable based on its Path Maximum Transmission Unit (PMTU; see {{Section 14.2 of QUIC-TRANSPORT}}), with @@ -1701,11 +1701,11 @@ ecn_ce_counters\[kPacketNumberSpace]: bytes_in_flight: : The sum of the size in bytes of all sent packets that contain at least one - ack-eliciting or PADDING frame, and have not been acknowledged or declared + ack-eliciting or PADDING frame and have not been acknowledged or declared lost. The size does not include IP or UDP overhead, but does include the QUIC - header and AEAD overhead. Packets only containing ACK frames do not count - towards bytes_in_flight to ensure congestion control does not impede - congestion feedback. + header and Authenticated Encryption with Associated Data (AEAD) overhead. + Packets only containing ACK frames do not count toward bytes_in_flight to + ensure congestion control does not impede congestion feedback. congestion_window: : Maximum number of bytes allowed to be in flight. @@ -1740,7 +1740,7 @@ for pn_space in [ Initial, Handshake, ApplicationData ]: ## On Packet Sent -Whenever a packet is sent, and it contains non-ACK frames, the packet +Whenever a packet is sent and it contains non-ACK frames, the packet increases bytes_in_flight. ~~~ @@ -1751,11 +1751,11 @@ OnPacketSentCC(sent_bytes): ## On Packet Acknowledgment -Invoked from loss detection's OnAckReceived and is supplied with the +This is invoked from loss detection's OnAckReceived and is supplied with the newly acked_packets from sent_packets. In congestion avoidance, implementers that use an integer representation -for congestion_window should be careful with division, and can use +for congestion_window should be careful with division and can use the alternative approach suggested in {{Section 2.1 of RFC3465}}. ~~~ @@ -1791,7 +1791,7 @@ OnPacketAcked(acked_packet): ## On New Congestion Event -Invoked from ProcessECN and OnPacketsLost when a new congestion event is +This is invoked from ProcessECN and OnPacketsLost when a new congestion event is detected. If not already in recovery, this starts a recovery period and reduces the slow start threshold and congestion window immediately. @@ -1812,7 +1812,7 @@ OnCongestionEvent(sent_time): ## Process ECN Information -Invoked when an ACK frame with an ECN section is received from the peer. +This is invoked when an ACK frame with an ECN section is received from the peer. ~~~ ProcessECN(ack, pn_space): @@ -1827,7 +1827,7 @@ ProcessECN(ack, pn_space): ## On Packets Lost -Invoked when DetectAndRemoveLostPackets deems packets lost. +This is invoked when DetectAndRemoveLostPackets deems packets lost. ~~~ OnPacketsLost(lost_packets): @@ -1857,7 +1857,7 @@ OnPacketsLost(lost_packets): ~~~ -## Removing Discarded Packets From Bytes In Flight +## Removing Discarded Packets from Bytes in Flight When Initial or Handshake keys are discarded, packets sent in that space no longer count toward bytes in flight.