From 7096acc350252061bed665a697f10964deae179b Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Tue, 2 Nov 2021 13:37:12 -0400 Subject: [PATCH 1/3] How to handle unknown stream type errors --- draft-ietf-quic-http.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index 2a6b0d3999..7bdb3ff008 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -1127,10 +1127,11 @@ create additional streams as allowed by their peer. If the stream header indicates a stream type that is not supported by the recipient, the remainder of the stream cannot be consumed as the semantics are -unknown. Recipients of unknown stream types MAY abort reading of the stream with -an error code of H3_STREAM_CREATION_ERROR or a reserved error code -({{http-error-codes}}), but MUST NOT consider such streams to be a connection -error of any kind. +unknown. Recipients of unknown stream types MUST either abort reading of the +stream or discard incoming data without further processing. If reading is +aborted, the recipient SHOULD use the H3_STREAM_CREATION_ERROR error code or a +reserved error code ({{http-error-codes}}). The recipient MUST NOT consider +unknown stream types to be a connection error of any kind. Implementations MAY send stream types before knowing whether the peer supports them. However, stream types that could modify the state or semantics of From 2031eedceaa8606663614f957baee67e6ccf3d68 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Tue, 2 Nov 2021 13:38:10 -0400 Subject: [PATCH 2/3] Section 9 alignment with Section 6.2 --- draft-ietf-quic-http.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index 7bdb3ff008..669a2886f7 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -1772,7 +1772,7 @@ managing these extension points: frame types ({{iana-frames}}), settings ({{iana-stream-types}}). Implementations MUST ignore unknown or unsupported values in all extensible -protocol elements. Implementations MUST discard frames and abort reading on +protocol elements. Implementations MUST discard data and/or abort reading on unidirectional streams that have unknown or unsupported types. This means that any of these extension points can be safely used by extensions without prior arrangement or negotiation. However, where a known frame type is required to be From cacdd9bdb9631db2cdefa326b70fb6a60305a863 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Mon, 15 Nov 2021 11:59:52 -0500 Subject: [PATCH 3/3] and/or --- draft-ietf-quic-http.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index 669a2886f7..a1ea242aeb 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -1223,16 +1223,16 @@ stream. This section describes HTTP/3 frame formats and their permitted stream types; see {{stream-frame-mapping}} for an overview. A comparison between HTTP/2 and HTTP/3 frames is provided in {{h2-frames}}. -| Frame | Control Stream | Request Stream | Push Stream | Section | -| -------------- | -------------- | -------------- | ----------- | ------------------------ | -| DATA | No | Yes | Yes | {{frame-data}} | -| HEADERS | No | Yes | Yes | {{frame-headers}} | -| CANCEL_PUSH | Yes | No | No | {{frame-cancel-push}} | -| SETTINGS | Yes (1) | No | No | {{frame-settings}} | -| PUSH_PROMISE | No | Yes | No | {{frame-push-promise}} | -| GOAWAY | Yes | No | No | {{frame-goaway}} | -| MAX_PUSH_ID | Yes | No | No | {{frame-max-push-id}} | -| Reserved | Yes | Yes | Yes | {{frame-reserved}} | +| Frame | Control Stream | Request Stream | Push Stream | Section | +| ------------ | -------------- | -------------- | ----------- | ---------------------- | +| DATA | No | Yes | Yes | {{frame-data}} | +| HEADERS | No | Yes | Yes | {{frame-headers}} | +| CANCEL_PUSH | Yes | No | No | {{frame-cancel-push}} | +| SETTINGS | Yes (1) | No | No | {{frame-settings}} | +| PUSH_PROMISE | No | Yes | No | {{frame-push-promise}} | +| GOAWAY | Yes | No | No | {{frame-goaway}} | +| MAX_PUSH_ID | Yes | No | No | {{frame-max-push-id}} | +| Reserved | Yes | Yes | Yes | {{frame-reserved}} | {: #stream-frame-mapping title="HTTP/3 Frames and Stream Type Overview"} The SETTINGS frame can only occur as the first frame of a Control stream; this @@ -1772,7 +1772,7 @@ managing these extension points: frame types ({{iana-frames}}), settings ({{iana-stream-types}}). Implementations MUST ignore unknown or unsupported values in all extensible -protocol elements. Implementations MUST discard data and/or abort reading on +protocol elements. Implementations MUST discard data or abort reading on unidirectional streams that have unknown or unsupported types. This means that any of these extension points can be safely used by extensions without prior arrangement or negotiation. However, where a known frame type is required to be @@ -2087,7 +2087,7 @@ its semantics, including any parts of the frame that are conditionally present. The entries in {{iana-frame-table}} are registered by this document. | ------------ | ------- | -------------------------- | -| Frame Type | Value | Specification | +| Frame Type | Value | Specification | | ------------ | :-----: | -------------------------- | | DATA | 0x00 | {{frame-data}} | | HEADERS | 0x01 | {{frame-headers}} |