From b1a925fc378bc17dd48f29663ab381c1f629b1e4 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Mon, 24 Jul 2017 11:09:32 -0700 Subject: [PATCH 1/3] ENABLE_PUSH instead of DISABLE_PUSH to match HTTP/2 --- draft-ietf-quic-http.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index cd0bb25183..17f72cdaf3 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -359,8 +359,8 @@ stream of the dependent request, not the data stream. HTTP/QUIC supports server push as described in {{!RFC7540}}. During connection establishment, the client indicates whether it is willing to receive server -pushes via the SETTINGS_DISABLE_PUSH setting in the SETTINGS frame (see -{{connection-establishment}}), which defaults to 1 (true). +pushes via the SETTINGS_ENABLE_PUSH setting in the SETTINGS frame (see +{{connection-establishment}}), which defaults to 0 (false). As with server push for HTTP/2, the server initiates a server push by sending a PUSH_PROMISE frame containing the Stream ID of the stream to be pushed, as well @@ -573,13 +573,13 @@ bytes than would be used to transfer the maximum permitted value. The following settings are defined in HTTP/QUIC: SETTINGS_HEADER_TABLE_SIZE (0x1): - : An integer with a maximum value of 2^32 - 1. + : An integer with a maximum value of 2^32 - 1 - SETTINGS_DISABLE_PUSH (0x2): - : Transmitted as a Boolean; replaces SETTINGS_ENABLE_PUSH + SETTINGS_ENABLE_PUSH (0x2): + : Transmitted as a Boolean SETTINGS_MAX_HEADER_LIST_SIZE (0x6): - : An integer with a maximum value of 2^32 - 1. + : An integer with a maximum value of 2^32 - 1 #### Usage in 0-RTT @@ -815,7 +815,7 @@ SETTINGS_HEADER_TABLE_SIZE: : See {{settings-parameters}}. SETTINGS_ENABLE_PUSH: -: See SETTINGS_DISABLE_PUSH in {{settings-parameters}}. +: See {{settings-parameters}}. SETTINGS_MAX_CONCURRENT_STREAMS: : QUIC requires the maximum number of incoming streams per connection to be @@ -1000,7 +1000,7 @@ Values for existing registrations are assigned by this document: | Setting Name | Supported Protocols | HTTP/QUIC Specification | |----------------------------|:-------------------:|-------------------------| | HEADER_TABLE_SIZE | Both | {{settings-parameters}} | -| ENABLE_PUSH / DISABLE_PUSH | Both | {{settings-parameters}} | +| ENABLE_PUSH | Both | {{settings-parameters}} | | MAX_CONCURRENT_STREAMS | HTTP/2 Only | N/A | | INITIAL_WINDOW_SIZE | HTTP/2 Only | N/A | | MAX_FRAME_SIZE | HTTP/2 Only | N/A | From e63858fa586e610554aa84f1adb26e464c4c4efc Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Mon, 24 Jul 2017 12:12:06 -0700 Subject: [PATCH 2/3] Changelog update --- draft-ietf-quic-http.md | 1 + 1 file changed, 1 insertion(+) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index aed2acf998..3222336ec9 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -1078,6 +1078,7 @@ The original authors of this specification were Robbie Shade and Mike Warres. ## Since draft-ietf-quic-http-04 - Cite RFC 5234 (#404) +- SETTINGS_ENABLE_PUSH instead of SETTINGS_DISABLE_PUSH (#477) ## Since draft-ietf-quic-http-03 From 2e07bdfa2b3bb83d8cf01d8d6e32b0dd074e0038 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Thu, 27 Jul 2017 10:50:00 -0700 Subject: [PATCH 3/3] Martin's feedback --- draft-ietf-quic-http.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-quic-http.md b/draft-ietf-quic-http.md index 3222336ec9..c2ee2d6fd3 100644 --- a/draft-ietf-quic-http.md +++ b/draft-ietf-quic-http.md @@ -363,7 +363,7 @@ stream of the dependent request, not the data stream. HTTP/QUIC supports server push as described in {{!RFC7540}}. During connection establishment, the client indicates whether it is willing to receive server pushes via the SETTINGS_ENABLE_PUSH setting in the SETTINGS frame (see -{{connection-establishment}}), which defaults to 0 (false). +{{connection-establishment}}), which is disabled by default. As with server push for HTTP/2, the server initiates a server push by sending a PUSH_PROMISE frame containing the Stream ID of the stream to be pushed, as well