From 8cbaaae4e1a634ebf7869244ed50a5eb78926579 Mon Sep 17 00:00:00 2001 From: ianswett Date: Mon, 13 Nov 2017 01:58:38 -0500 Subject: [PATCH 1/2] Use time_of_last_sent_packet time_of_last_sent_packet should be used to set the loss detection timer, instead of using now. --- draft-ietf-quic-recovery.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index 5bf8712edd..d7df32d6dd 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -687,7 +687,7 @@ Pseudocode for SetLossDetectionAlarm follows: alarm_duration = alarm_duration * (2 ^ handshake_count) else if (loss_time != 0): // Early retransmit timer or time loss detection. - alarm_duration = loss_time - now + alarm_duration = loss_time - time_of_last_sent_packet else if (tlp_count < kMaxTLPs): // Tail Loss Probe if (num_retransmittable_packets_outstanding == 1): @@ -701,7 +701,7 @@ Pseudocode for SetLossDetectionAlarm follows: alarm_duration = max(alarm_duration, kMinRTOTimeout) alarm_duration = alarm_duration * (2 ^ rto_count) - loss_detection_alarm.set(now + alarm_duration) + loss_detection_alarm.set(time_of_last_sent_packet + alarm_duration) ~~~ ### On Alarm Firing From aa00e34549f0193f20570d608563f9253720cc43 Mon Sep 17 00:00:00 2001 From: Mike Bishop Date: Tue, 14 Nov 2017 09:40:14 +0800 Subject: [PATCH 2/2] Break long line in pseudocode --- draft-ietf-quic-recovery.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/draft-ietf-quic-recovery.md b/draft-ietf-quic-recovery.md index d7df32d6dd..03a4c903e2 100644 --- a/draft-ietf-quic-recovery.md +++ b/draft-ietf-quic-recovery.md @@ -701,7 +701,8 @@ Pseudocode for SetLossDetectionAlarm follows: alarm_duration = max(alarm_duration, kMinRTOTimeout) alarm_duration = alarm_duration * (2 ^ rto_count) - loss_detection_alarm.set(time_of_last_sent_packet + alarm_duration) + loss_detection_alarm.set(time_of_last_sent_packet + + alarm_duration) ~~~ ### On Alarm Firing