New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff() and Unicode surrogate pairs #40

Closed
Calyhre opened this Issue Feb 7, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@Calyhre
Copy link

Calyhre commented Feb 7, 2019

Since quill-delta has moved to fast-diff@1.2.0, who now is unicode-safe (jhchen/fast-diff#4), using .diff() on document that has a retain leading to a unicode surrogate pair being broke, there is a Maximum call stack size exceeded error.

Here is in 4.0.1 without error: https://repl.it/repls/PungentColorfulScandisk
And in 4.1.0 with the error: https://repl.it/repls/FrailLimitedCoolingfan

My guess is that as quill-delta is not unicode-safe, any used dependency shouldn't be neither

@jhchen

This comment has been minimized.

Copy link
Member

jhchen commented Feb 11, 2019

This seems to be a bug with fast-diff. Can you post an issue there?

@jhchen jhchen closed this Feb 11, 2019

@Calyhre

This comment has been minimized.

Copy link
Author

Calyhre commented Feb 11, 2019

Will do, but that would still be an issue to have a unicode aware dependency and not quill-delta no?

@jhchen

This comment has been minimized.

Copy link
Member

jhchen commented Feb 13, 2019

quill-delta's unicode awareness comes from fast-diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment