Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Chrome 65 update breaks start of CJK IME input #2009

Closed
berylw opened this issue Mar 9, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@berylw
Copy link

commented Mar 9, 2018

With the latest Chrome 65 update, inputting CJK (Chinese, Japanese, Korean) characters using IME breaks the first character out of composition. Maybe Chrome changed something with how they send composition events? Note: this issue only occurs at the very start of a new line.

quill

Steps for Reproduction

  1. Download Japanese keyboard. On a Mac, the steps are: System Preferences > Language & Region > Keyboard Preferences > Input Sources > Add Japanese
  2. Visit quilljs.com/playground
  3. Switch to (Hiragana) Japanese IME using cmd + space
  4. Try to type the Japanese character by typing ha and then hitting enter
  5. Instead of , we end up with hあ (a -> )

Expected behavior:
We get

The compositionstart event triggered by pressing h is properly handled. The line below the character indicating that the user is in the middle of a composition remains intact while the user presses a to form the character until the user hits enter, at which point we reach compositionend.

Actual behavior:
We get hあ

Maybe Chrome is sending multiple compositionstart events and Quill is not handling them properly, or is doing something else to interrupt the composition once the first character is typed?

Platforms:
Chrome 65 on macOS High Sierra
IE11 on Windows, reportedly

Version:
1.2.6

@hejianghu

This comment has been minimized.

Copy link

commented Mar 12, 2018

I got in the same situation, did you find the resolution?

@WinMinTun

This comment has been minimized.

Copy link

commented Sep 12, 2018

@jhchen @benbro @berylw @dalehe Can some of you shed me some light on how did you solve it? I saw u update the version of Parchment. I m writing authorship module and having the same problem (with any Chinese Pinyin pop up keyboards like IME) whenever I call updateContents to style author info into the delta. I desperately need an authorship module. Here is the module https://github.com/WinMinTun/quill-authorship Pls refer to #2305

@WinMinTun

This comment has been minimized.

Copy link

commented Sep 16, 2018

@benbro @berylw @dalehe A related big issue regarding IME keyboards in collaborative environment. I think it is not directly because of Quill. But it is a big issue and really need attention to it. IME keyboards are not working in collaborative editing as composition disrupts upon others' changes #2314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.