Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill.insertText() buggy formatting #782

Closed
dmonad opened this issue Jul 4, 2016 · 2 comments
Closed

quill.insertText() buggy formatting #782

dmonad opened this issue Jul 4, 2016 · 2 comments

Comments

@dmonad
Copy link

dmonad commented Jul 4, 2016

Under circumstances, quill.insertText(pos, text, format) doesn't behave correctly:

Steps for Reproduction

  1. Visit beta.quilljs.com (or use quill@1.0.0-beta.6)
  2. quill.setContents([{"insert":"s"},{"attributes":{"bold":true},"insert":"s"},{"insert":"XXXXX"},{"attributes":{"strike":true},"insert":"HHH"},{"insert":"\n\n\n"}])
  3. quill.insertText(10, 'iiiiii', { bold: false, strike: false })

Expected behavior: The inserted text 'iiiiii' is not bold

Actual behavior: The inserted text is bold

Platforms: Chrome Version 51.0.2704.106 (64-bit)

@sahanDissanayake
Copy link

I think I'm facing the same issue,

When I try to inside some text inside a bold, italic text the text inserted should inherit the styles from the parent right ?

dmonad added a commit to y-js/y-richtext that referenced this issue Jul 5, 2016
@dmonad
Copy link
Author

dmonad commented Jul 5, 2016

@sahanDissanayake To my understanding you are right. But you are facing a different issue. I explicitly stated that the inserted text should not be bold, but it turned out to be bold. I think you should open another issue with steps to reproduce your issue.

@jhchen jhchen closed this as completed in 5463364 Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants