Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat as * as another trigger for bullet lists #1819

Merged
merged 1 commit into from Nov 18, 2017

Conversation

@LFDM
Copy link
Contributor

commented Nov 13, 2017

Taking on #1808, treating * the same as - to trigger a bullet list quicker than going through the toolbar.

@LFDM

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

Are these tests flaky somehow? I don't think these changes should have any effect on Safari failing to run...

@jhchen

This comment has been minimized.

Copy link
Member

commented Nov 16, 2017

Yes looks like sauce labs failed to start Safari even with three tries. One stylistic change request: Can you do case '-': case '*': similar to how the checklist works (a few lines above)?

@LFDM LFDM force-pushed the LFDM:feat/bullet-list-with-asterisk branch from 3c88711 to 76b5424 Nov 18, 2017
@LFDM

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2017

Ah yes, sorry - forgot to force push after making these style changes last time. Done now!

@jhchen

This comment has been minimized.

Copy link
Member

commented Nov 18, 2017

Great thanks!

@jhchen jhchen merged commit 845f9f1 into quilljs:develop Nov 18, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.