Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket icons #1152

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@dimaryaz
Copy link
Member

commented Sep 17, 2019

/api/buckets returns 'icon_url' rather than 'icon'

/api/buckets returns 'icon_url' rather than 'icon'
@dimaryaz dimaryaz requested review from akarve and kevinemoore Sep 17, 2019
@dimaryaz dimaryaz self-assigned this Sep 17, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #1152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          26       26           
  Lines        3563     3563           
=======================================
  Hits         3120     3120           
  Misses        443      443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd18d5...4849dba. Read the comment docs.

@dimaryaz dimaryaz merged commit 458df0d into master Sep 17, 2019
6 checks passed
6 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-3.6 Your tests passed on CircleCI!
Details
ci/circleci: test-lambdas-indexer Your tests passed on CircleCI!
Details
ci/circleci: test-lambdas-preview Your tests passed on CircleCI!
Details
ci/circleci: test-lambdas-s3select Your tests passed on CircleCI!
Details
ci/circleci: test-lambdas-shared Your tests passed on CircleCI!
Details
@dimaryaz dimaryaz deleted the fix_icon branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.