Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use create file functionality for "Add README" button #3173

Merged
merged 5 commits into from Nov 7, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 4, 2022

Screenshot from 2022-11-04 22-05-33
Screenshot from 2022-11-04 22-05-40

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #3173 (d55e2c0) into master (49ca588) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
+ Coverage   34.98%   35.00%   +0.02%     
==========================================
  Files         661      661              
  Lines       29007    28985      -22     
  Branches     4263     4263              
==========================================
  Hits        10147    10147              
+ Misses      17672    17650      -22     
  Partials     1188     1188              
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.29% <0.00%> (+<0.01%) ⬆️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Summary.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 November 6, 2022 16:44
@fiskus fiskus merged commit 9187038 into master Nov 7, 2022
@fiskus fiskus deleted the add-readme-reuse-create-file branch November 7, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants