upgrade JS stuff #326
Merged
upgrade JS stuff #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asah
requested review from
kevinemoore and
akarve
and removed request for
kevinemoore
akarve
requested changes
Feb 5, 2018
There was a problem hiding this comment.
Refuses to build:
ERROR in chunk main [entry]
[name].[chunkhash].js
'import' and 'export' may only appear at the top level (65:6)
| if (false) {
| module.hot.accept('./reducers', function () {
| import('./reducers').then(function (reducerModule) {
| var createReducers = reducerModule.default;
| var nextReducers = createReducers(store.asyncReducers);
Child html-webpack-plugin for "index.html":
1 asset
npm ERR! code ELIFECYCLE
And fails lint:
/Users/karve/code/quilt/catalog/app/components/Demo/index.js
17:11 error <iframe> elements must have a unique title property jsx-a11y/iframe-has-title
/Users/karve/code/quilt/catalog/app/components/Feature/index.js
27:9 error <iframe> elements must have a unique title property jsx-a11y/iframe-has-title
/Users/karve/code/quilt/catalog/app/components/Help/index.js
18:9 error Expected indentation of 6 space characters but found 8 react/jsx-indent
/Users/karve/code/quilt/catalog/app/components/LayoutHelpers/index.js
3:8 error 'React' is defined but never used no-unused-vars
/Users/karve/code/quilt/catalog/app/components/PackageList/index.js
42:9 error Missing parentheses around multilines JSX react/jsx-wrap-multilines
/Users/karve/code/quilt/catalog/app/components/Pagination/index.js
83:3 error Missing parentheses around multilines JSX react/jsx-wrap-multilines
/Users/karve/code/quilt/catalog/app/components/Values/messages.js
7:5 error Expected indentation of 2 space characters but found 4 react/jsx-indent
15:5 error Expected indentation of 2 space characters but found 4 react/jsx-indent
23:5 error Expected indentation of 2 space characters but found 4 react/jsx-indent
30:5 error Expected indentation of 2 space characters but found 4 react/jsx-indent
✖ 10 problems (10 errors, 0 warnings)
This is after a merge with master.
|
@akarve this one is work in progress, so not expected to be properly runnable) |
nl0
force-pushed
the
upgrade-stuff
branch
2 times, most recently
from
d891e58
to
3ea2524
Compare
|
@akarve ok, now it should work. The branch has been rebased onto the latest master. I'll quote the commit message that sums up the changes: Upgrade lots of stuff, most notable changes:
Also, all the dependecnies are now stated with the caret (^) syntax. Changes introduced to make things work with the updated dependencies:
|
This was referenced Feb 6, 2018
Merged
|
Nice.
Here's the error I got: |
|
Upgrade lots of stuff, most notable changes: * webpack@3 & webpack-dev-middleware@2 * react@16 * material-ui@0.20 * styled-components@3 * enzyme@3 * `env` babel presets instead of `latest` Also, all the dependecnies are now stated with the caret (^) syntax. Changes introduced to make things work with the updated dependencies: * use `prop-types` packages * update webpack configs * backport some changes from react-boilerplate@3.5 * update code according to the new linting rules * make test stubs pass
|
@akarve done |
akarve
approved these changes
Feb 10, 2018
nl0
added a commit
to nl0/quilt
that referenced
this pull request
Feb 13, 2018
* master: (38 commits) Implement the "always requires auth" catalog config (quiltdata#365) Replace a confusing SQL query with a slightly less confusing one (quiltdata#363) Eliminate stray back-tick [ci skip] Eliminate redundant `.team` [ci skip] Whack backticks [ci skip] fix syntax example; refactor headings [ci skip] Add alternative terms [ci skip] Link to object store docs [ci skip] Consolidate and move sections [ci skip] Rename section [ci skip] Simplify and update links [ci skip] Rename section [ci skip] Add notes on immutability, tophash, etc. [ci skip] Use a small dataset in most of the tests (quiltdata#360) Add (No results) to empty search results (quiltdata#359) Admin UI endpoint to list users and associated data (quiltdata#354) Upgrade the stack (quiltdata#326) build.yml globbing (quiltdata#287) Pass the DISABLE_SIGNUP env variable to django (quiltdata#356) use npm lock files, delete yarn (quiltdata#355) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade lots of stuff, most notable changes:
webpack@3 & webpack-dev-middleware@2
react@16
material-ui@0.20
styled-components@3
enzyme@3
envbabel presets instead oflatestAlso, all the dependecnies are now stated with the caret (^) syntax.
Changes introduced to make things work with the updated dependencies:
use
prop-typespackagesupdate webpack configs
backport some changes from react-boilerplate@3.5
update code according to the new linting rules
make test stubs pass