Dashboards + misc browser UI adjustments #8
Conversation
| * | ||
| * @param {Object} md Remarkable instance | ||
| * @param {Object} options |
There was a problem hiding this comment.
This looks slightly incorrect to me -- I think as it is, this declares a function of 3 parameters, when really you want a function with 1 parameter that has 2 destructure parameters. See "Documenting a destructuring parameter" in http://usejsdoc.org/tags-param.html
Also, if you could document the return type, I would appreciate that.
| @@ -63,6 +80,8 @@ const adjustLinks = (md) => { | |||
| md.renderer.rules.link_open = (tokens, idx) => { | |||
| const t = tokens[idx]; | |||
| const title = t.title ? ` title="${escape(t.title)}"` : ''; | |||
| // TODO: sign | |||
There was a problem hiding this comment.
i think we need to sign the links as well, not only images, so i've left this TODO
There was a problem hiding this comment.
OK so this PR isn't done till this is fixed?
|
|
||
|
|
||
| const DEFAULT_URL_EXPIRATION = 5 * 60; // in seconds |
There was a problem hiding this comment.
why isn't this imported from /constants?
There was a problem hiding this comment.
because it's a default value. if we want to configure this, we should add a config value and then use it when instantiating the provider in app.js
|
@akarve now this one looks complete |
|
docs added |
nl0
changed the title
TODO
Dashboards
Misc browser UI adjustments