From 9bf40fb311753b04fb38967eb058c976f888dfcf Mon Sep 17 00:00:00 2001
From: Elijah DeLee <kdelee@redhat.com>
Date: Wed, 20 Sep 2017 11:31:21 -0400
Subject: [PATCH] Poll remote servers until live.

It takes time between the power on signal is sent to the remote servers
and they are available over ssh for rho. These changes make it so
servers are polled until they respond or a timeout limit is reached.

Closes #28
---
 camayoc/tests/remote/conftest.py | 42 ++++++++++++++++++++++++++++++--
 1 file changed, 40 insertions(+), 2 deletions(-)

diff --git a/camayoc/tests/remote/conftest.py b/camayoc/tests/remote/conftest.py
index f22e3a91..254417fa 100644
--- a/camayoc/tests/remote/conftest.py
+++ b/camayoc/tests/remote/conftest.py
@@ -2,7 +2,7 @@
 """Pytest customizations and fixtures for tests to execute on remote hosts."""
 import os
 import pytest
-from camayoc import config
+from camayoc import cli, config
 from camayoc.exceptions import ConfigFileNotFoundError
 from time import sleep
 from camayoc.constants import (
@@ -12,6 +12,42 @@
 )
 
 
+def is_live(client, server, num_pings=10):
+    """Test if server responds to ping.
+
+    Returns true if server is reachable, false otherwise.
+    """
+    client.response_handler = cli.echo_handler
+
+    ping = client.run(('ping', '-c', num_pings, server))
+    return ping.returncode == 0
+
+
+def wait_until_live(servers, timeout=60):
+    """Wait for servers to be live.
+
+    For each server in the "servers" list, verify if it is reachable.
+    Keep trying until a connection is made for all servers or the timeout
+    limit is reached.
+
+    If the timeout limit is reached, we exit even if there are unreached hosts.
+    This means tests could fail with "No auths valid for this profile" if every
+    host in the profile is unreachable. Otherwise, if there is at least one
+    valid host, the scan will go on and only facts about reached hosts will be
+    tested.
+
+    `See rho issue #302 <https://github.com/quipucords/rho/issues/302>`_
+    """
+    system = cli.System(hostname='localhost', transport='local')
+    client = cli.Client(system)
+
+    unreached = servers
+    while unreached and timeout > 0:
+        unreached = [host for host in unreached if not is_live(client, host)]
+        sleep(10)
+        timeout -= 10
+
+
 @pytest.fixture(scope='session', autouse=True)
 def manage_systems(request):
     """Fixture that manages remote systems.
@@ -100,15 +136,17 @@ def manage_systems(request):
         vm_host = fldr.childEntity[VCENTER_CLUSTER].host[VCENTER_HOST]
         # the host has a property "vm" which is a list of VMs
         vms = vm_host.vm
+        vc_hosts = []
         for host in cfg['rho']['hosts']:
             if ('provider' in host.keys()) and (
                     host['provider'] == 'vcenter'):
+                vc_hosts.append(host['ip'])
                 for vm in vms:
                     if vm.name == host['hostname']:
                         if vm.runtime.powerState == 'poweredOff':
                             vm.PowerOnVM_Task()
         # need to wait for machines to boot and start sshd
-        sleep(30)
+        wait_until_live(vc_hosts)
 
     def shutdown_systems():
         """Turn off hosts at the end of a session.