Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] 1.21 Support #408

Closed
Spike-has-no-idea-how-to-code opened this issue Jun 29, 2024 · 13 comments
Closed

[Suggestion] 1.21 Support #408

Spike-has-no-idea-how-to-code opened this issue Jun 29, 2024 · 13 comments

Comments

@Spike-has-no-idea-how-to-code

Description

I enjoy using better nether and better end, however upon updating to 1.21, I realized that Better End had not been updated with all the other mods. Maybe you guys are working on it, maybe you aren't, but I haven't seen anyone in issues ask for it, and the code hasn't had a new commit in half a year. This is mildly annoying specifically because I cannot play the game without Better End, as Minecraft can't boot up a world that has better end data inside. I simply have no way of knowing if this is being worked on so I had to make a suggestion about it just in case.

@Spike-has-no-idea-how-to-code
Copy link
Author

Update: upon looking in the pull requests, I realized that 1.21 is in here somewhere, but this is a maze of forks that is insanely hard to navigate. I hail from modrinth, foolishly assuming that all the devs would use the same repo as the one that is linked at the actual download site. I have no idea what is going on, but i have a feeling that either the link takes you to the wrong fork or there is some spaghettification shenanigans happening

@Spike-has-no-idea-how-to-code
Copy link
Author

Another update: I'm stupid its the same repo but i didnt realize it took me to 1.20.3 branch, sorry to have made this oops

@KennyDevT
Copy link

Do Not Compile the 1.21 branch it is unstable and broken for now. Please be patient.

@KennyDevT
Copy link

Nvm New version just released a few seconds ago.

@KennyDevT
Copy link

KennyDevT commented Jun 29, 2024

Nvm again new version is broken.

@Spike-has-no-idea-how-to-code
Copy link
Author

are you referring to the deprecated gradle features error? just making sure i havent made a mistake

@KennyDevT
Copy link

No the mod it self is broken rn.

@Spike-has-no-idea-how-to-code
Copy link
Author

oh well i cant build it, do you know how I can change gradle versions so that I'm not using the one that has deprecated the features this mod needs?

@KennyDevT
Copy link

that is not the issue you simply do not have the libraries and as i said please be patient and dont compile rn.

@OpenBagTwo
Copy link

Just FYI—if you want to build the mod yourself, you need to do the following:

  1. Clone these four repos to and check out the following branches for each (making sure to use --recurse-submodules for WorldWeaver):
  2. Make sure all four repos are in the same parent directory, i.e.
    My Workspaces
    ├── BetterX
    |    ├── BCLib
    |    ├── BetterEnd
    |    ├── WorldWeaver
    |    ├── Wunderlib
    
  3. Open BetterEnd in IntelliJ (or Eclipse or whatever), set up gradle, and run the build task
  4. Copy the built mods from each repo's build/libs folder into your Minecraft instance

@KennyDevT
Copy link

Yeah ik its just that the mod is like broken rn some models straight dont render but your pr fixes that so i guess if he uses your pr he should be fine. And even at that he should wait for the wings to be fixed.

@OpenBagTwo
Copy link

Definitely do not recommend upgrading right now—looks like you can generate new worlds, but old worlds will be completely borked:

[22:32:31] [Render thread/ERROR]: Unknown registry key in ResourceKey[minecraft:root / minecraft:worldgen/chunk_generator]: bclib:betterx; Unknown registry key in ResourceKey[minecraft:root / minecraft:worldgen/chunk_generator]: bclib:betterx missed input: {"minecraft:the_end":{biome_source:{config:{barrens_biomes_size:256,center_biomes_size:256,generator_version:"paulevs",inner_void_radius_squared:1048576,land_biomes_size:256,map_type:"hex",void_biomes_size:256,with_void_biomes:1b},seed:0L,type:"bclib:end_biome_source"},settings:"minecraft:end",type:"bclib:betterx"},"minecraft:the_nether":{biome_source:{config:{amplified:0b,biome_size:256,biome_size_vertical:86,map_type:"hex",use_vertical_biomes:1b},seed:0L,type:"bclib:nether_biome_source"},settings:"minecraft:nether",type:"bclib:betterx"}}

@KennyDevT
Copy link

And it crashes randomly too so def do update yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants