contextMatchesOptions tests fail #124

merged 1 commit into from Apr 21, 2012


None yet

6 participants

rikkert commented Jan 24, 2012

In version 0.7.1 most contextMatchesOptions tests fail.
This should fix it.

The bug this fixes breaks my app - have had to use 0.70. (I'm trying to use Sammy.before({except: ... )

Would definitely be a good one to fix.

+1 on this!

smerik commented Feb 23, 2012


@quirkey quirkey merged commit edbbd3f into quirkey:master Apr 21, 2012

This commit has broken path checks when using app.contextMatchesOptions(context, /some-reg-expression-path/) - it always returns true.

@rikkert rikkert added a commit to rikkert/sammy that referenced this pull request May 23, 2012
@rikkert rikkert Make pull request #124 actually work.
This fixes #140 where a regexp object as option was not recognized.
Adds _isRegExp() to do easy check for regexp objects.
Makes all Sammy.Application contextMatchesOptions tests pass and adds
test should match against undefined options.
rikkert commented May 23, 2012

Good catch, made it all work in pull request 141 for your issue #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment