Try not using threads in Consumer tests

quixio · Sep 26, 2023 · e3539b0 · e3539b0
1 parent e4608df
commit e3539b0
Show file tree

Hide file tree

Showing 5 changed files with 156 additions and 181 deletions.
diff --git a/.github/workflows/streamingdataframes-ci.yml b/.github/workflows/streamingdataframes-ci.yml
@@ -71,7 +71,7 @@ jobs:
           python -m pip install -U -r requirements.txt
       - name: Run tests
         run: |
-          python -m pytest -s -v
+          python -m pytest -s -v -k TestConsumer
 
 
 #  build:

diff --git a/src/StreamingDataFrames/streamingdataframes/kafka/consumer.py b/src/StreamingDataFrames/streamingdataframes/kafka/consumer.py
@@ -105,7 +105,6 @@ def __init__(
             },
         )
         self._inner_consumer: Optional[ConfluentConsumer] = None
-        self._running = True
 
     def poll(self, timeout: float = None) -> Optional[Message]:
         """
@@ -498,13 +497,4 @@ def __enter__(self):
         return self
 
     def __exit__(self, exc_type, exc_val, exc_tb):
-        self._running = False
         self.close()
-
-    @property
-    def running(self) -> bool:
-        """
-        Check if the consumer is running.
-        Note: To be used for testing only.
-        """
-        return self._running