New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Adds an editorconfig #115

Closed
wants to merge 2 commits into
from

Conversation

6 participants
@ebenoist
Contributor

ebenoist commented Oct 27, 2015

Adds an editorconfig file to establish minimal standards for edits to any project file

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Oct 28, 2015

Member

This should follow the discussion on #114 (comment)

Member

leobalter commented Oct 28, 2015

This should follow the discussion on #114 (comment)

@leobalter

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Oct 28, 2015

Member

Though this should be fine to land as-is now, we can improve it later.

Member

jzaefferer commented Oct 28, 2015

Though this should be fine to land as-is now, we can improve it later.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Oct 28, 2015

Contributor

The package.json file uses 2 space indentation.

Contributor

arthurvr commented Oct 28, 2015

The package.json file uses 2 space indentation.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Oct 28, 2015

Member

The package.json is mostly updated through npm, which always rewrites it after a npm install --save or npm version.

We may follow the suggestion on the editorconfig website:

# Matches the exact files either package.json or .travis.yml
[{package.json,.travis.yml}]
indent_style = space
indent_size = 2
Member

leobalter commented Oct 28, 2015

The package.json is mostly updated through npm, which always rewrites it after a npm install --save or npm version.

We may follow the suggestion on the editorconfig website:

# Matches the exact files either package.json or .travis.yml
[{package.json,.travis.yml}]
indent_style = space
indent_size = 2
@ebenoist

This comment has been minimized.

Show comment
Hide comment
@ebenoist

ebenoist Nov 1, 2015

Contributor

I went ahead and added rules for *.json and *.yml files. Let me know if I should add anything else.

Contributor

ebenoist commented Nov 1, 2015

I went ahead and added rules for *.json and *.yml files. Let me know if I should add anything else.

trim_trailing_whitespace = true
insert_final_newline = true
[*.{json,yml}]

This comment has been minimized.

@jzaefferer

jzaefferer Nov 2, 2015

Member

This should be specific to the affected files, [{package.json,.travis.yml}].

@jzaefferer

jzaefferer Nov 2, 2015

Member

This should be specific to the affected files, [{package.json,.travis.yml}].

This comment has been minimized.

@ebenoist

ebenoist Nov 2, 2015

Contributor

I can possibly see that for *.json, but shouldn't yml always be two space indented?

@ebenoist

ebenoist Nov 2, 2015

Contributor

I can possibly see that for *.json, but shouldn't yml always be two space indented?

This comment has been minimized.

@jzaefferer

jzaefferer Nov 2, 2015

Member

You're right, that's in the spec: http://yaml.org/spec/current.html#id2519916 - apparently the amount doesn't matter, but sticking with 2 makes sense.

@jzaefferer

jzaefferer Nov 2, 2015

Member

You're right, that's in the spec: http://yaml.org/spec/current.html#id2519916 - apparently the amount doesn't matter, but sticking with 2 makes sense.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Dec 9, 2015

Contributor

Let's not let the larger discussion hold this up. @leobalter is there anything stopping this from being merged?

Contributor

scottgonzalez commented Dec 9, 2015

Let's not let the larger discussion hold this up. @leobalter is there anything stopping this from being merged?

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Dec 9, 2015

Member

It LGTM.

Member

leobalter commented Dec 9, 2015

It LGTM.

@leobalter leobalter closed this in 2365986 Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment