Fix test duration/runtime #395

Closed
jzaefferer opened this Issue Jan 20, 2013 · 3 comments

Projects

None yet

3 participants

@jzaefferer
Owner

Originally added in #344, but has some shortcomings. Should use "runtime" instead of "duration", to make it consistent with the property passed to the done callback.

Should also be provided for modules, not just tests.

See also de2353a#commitcomment-2414467

Owner

Very much agreed! 👍

Owner
Krinkle commented Jan 24, 2013

It seems like the duration test is subject to a race condition. setTimeout isn't reliable. We need to give it more slack/tolerance.

@jzaefferer jzaefferer added a commit that closed this issue Jan 3, 2014
@jzaefferer jzaefferer Logging: Add runtime property to testDone, deprecate duration
Will remove duration in 2.0.0, runtime does the same thing and is consistent
with the runtime property on the done callback.

Fixes #395
4eb4cfd
@jzaefferer jzaefferer closed this in 4eb4cfd Jan 3, 2014
Owner

Added runtime, deprecating the duration property on testDone. Created #499 to add the runtime property for moduleDone and #500 to remove the duration property in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment