Improve or drop phantomjs add-on #420

Closed
jzaefferer opened this Issue Mar 3, 2013 · 9 comments

Comments

Projects
None yet
4 participants
@jzaefferer
Owner

jzaefferer commented Mar 3, 2013

We should either remove the phantomjs addon and refer to other solutions like https://github.com/gruntjs/grunt-contrib-qunit or move the add-on to a standalone repository and work with for example the grunt guys to make this add-on useful to them, so that they can actually use it instead of maintaining their own integration. Even if that doesn't happen, it should at least replace the bundled example, which is really bad: https://github.com/ariya/phantomjs/blob/master/examples/run-qunit.js
Maybe we can just contribute the add-on to phantomjs and help them maintain that copy, instead of our own repo.

@JamesMGreene @Krinkle what do you think?

@JamesMGreene

This comment has been minimized.

Show comment Hide comment
@JamesMGreene

JamesMGreene Mar 3, 2013

Owner

I'd say contribute it to the PhantomJS example scripts, remove it from the QUnit repo, and then focus efforts on improving grunt-contrib-qunit instead.

Owner

JamesMGreene commented Mar 3, 2013

I'd say contribute it to the PhantomJS example scripts, remove it from the QUnit repo, and then focus efforts on improving grunt-contrib-qunit instead.

@JamesMGreene

This comment has been minimized.

Show comment Hide comment
@JamesMGreene

JamesMGreene Mar 3, 2013

Owner

Well, unless you are confident we can make a standalone version of this useful to the Grunt folks....?

@cowboy @ctalkington @tkellen Thoughts?

Owner

JamesMGreene commented Mar 3, 2013

Well, unless you are confident we can make a standalone version of this useful to the Grunt folks....?

@cowboy @ctalkington @tkellen Thoughts?

@cowboy

This comment has been minimized.

Show comment Hide comment
@cowboy

cowboy Mar 3, 2013

If you have any interest in contributing to (or maintaining) the official grunt-contrib-qunit plugin and grunt-lib-phantomjs lib, we'd be very appreciative for the help!

Also, if you make a standalone version that can be back-ported into the Grunt plugin or the aforementioned lib, that would be great. What I wrote works pretty well, but I'm sure it could be improved upon.

cowboy commented Mar 3, 2013

If you have any interest in contributing to (or maintaining) the official grunt-contrib-qunit plugin and grunt-lib-phantomjs lib, we'd be very appreciative for the help!

Also, if you make a standalone version that can be back-ported into the Grunt plugin or the aforementioned lib, that would be great. What I wrote works pretty well, but I'm sure it could be improved upon.

@ghost ghost assigned JamesMGreene Mar 9, 2013

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Mar 14, 2013

Owner

There's certainly enough interest in this plugin (no more add-ons), so we'll keep it. Have still to figure out where and how it should live on. Not everyone uses grunt, but if the grunt plugin can use it, all the better.

We should also send a PR or something to eventually replace the thing bundled with PhantomJS.

Owner

jzaefferer commented Mar 14, 2013

There's certainly enough interest in this plugin (no more add-ons), so we'll keep it. Have still to figure out where and how it should live on. Not everyone uses grunt, but if the grunt plugin can use it, all the better.

We should also send a PR or something to eventually replace the thing bundled with PhantomJS.

@JamesMGreene

This comment has been minimized.

Show comment Hide comment
@JamesMGreene

JamesMGreene Mar 14, 2013

Owner

Regarding the PhantomJS-bundled "run-qunit.js" example: ariya/phantomjs#412 (comment)

cc: @ariya

Owner

JamesMGreene commented Mar 14, 2013

Regarding the PhantomJS-bundled "run-qunit.js" example: ariya/phantomjs#412 (comment)

cc: @ariya

@ghost ghost assigned Krinkle May 6, 2013

@JamesMGreene

This comment has been minimized.

Show comment Hide comment
@JamesMGreene

JamesMGreene May 6, 2013

Owner

I reassigned this to @Krinkle for now as he is planning to take ownership of the PhantomJS plugin.

Owner

JamesMGreene commented May 6, 2013

I reassigned this to @Krinkle for now as he is planning to take ownership of the PhantomJS plugin.

@ghost ghost assigned JamesMGreene Oct 10, 2013

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Jan 3, 2014

Owner

@JamesMGreene since Timo never create a repo for the plugin, would you be interested in taking that over? I really want to remove the code from this repo asap.

Owner

jzaefferer commented Jan 3, 2014

@JamesMGreene since Timo never create a repo for the plugin, would you be interested in taking that over? I really want to remove the code from this repo asap.

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Jan 29, 2014

Owner

This is gone from master and won't be in 1.14 anymore. Anyone interested in this script is welcome to host it in a new repo.

Owner

jzaefferer commented Jan 29, 2014

This is gone from master and won't be in 1.14 anymore. Anyone interested in this script is welcome to host it in a new repo.

@JamesMGreene

This comment has been minimized.

Show comment Hide comment
@JamesMGreene

JamesMGreene Feb 5, 2014

Owner
Owner

JamesMGreene commented Feb 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment