New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warnings for deprecated features. #881

Closed
leobalter opened this Issue Oct 21, 2015 · 7 comments

Comments

3 participants
@leobalter
Member

leobalter commented Oct 21, 2015

QUnit should throw warnings (reporter/console) for deprecated features, including:

  • use of global methods instead of the namespaced methods. (some can be easily fixed with local variables like: var test = QUnit.test;)
  • use of stop/start methods
  • etc

Also it should mention the qunit-migrate tools.

@leobalter leobalter added this to the v2.0 milestone Oct 21, 2015

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Oct 22, 2015

Member

I don't think we need an additional migration layer. 2.0 will throw helpful errors for removed features, for anything not yet migrated.

Member

jzaefferer commented Oct 22, 2015

I don't think we need an additional migration layer. 2.0 will throw helpful errors for removed features, for anything not yet migrated.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Oct 22, 2015

Member

Having warnings for deprecated features on 1.x helps on the migration process, so a run using the last 1.x without any warnings would result on a safe and clean migration to 2.0

Member

leobalter commented Oct 22, 2015

Having warnings for deprecated features on 1.x helps on the migration process, so a run using the last 1.x without any warnings would result on a safe and clean migration to 2.0

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Oct 30, 2015

Member

After talking on a meeting today with @jzaefferer, we decided to keep this issue and land it before QUnit 2.0

Member

leobalter commented Oct 30, 2015

After talking on a meeting today with @jzaefferer, we decided to keep this issue and land it before QUnit 2.0

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Dec 10, 2015

Member

There should be an option to disable the warnings. For example, in jQuery UI there's the $.uiBackCompat` flag, which turns off the back-compat layer, to test if the next release (where deprecated features are dropped) will still work. That's different from warnings, but we can do something similar here.

Member

jzaefferer commented Dec 10, 2015

There should be an option to disable the warnings. For example, in jQuery UI there's the $.uiBackCompat` flag, which turns off the back-compat layer, to test if the next release (where deprecated features are dropped) will still work. That's different from warnings, but we can do something similar here.

@raphamorim raphamorim referenced this issue Jan 12, 2016

Closed

Warnings API for deprecated features #918

13 of 13 tasks complete
@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Apr 18, 2016

Member

Is this still valid?

Member

jzaefferer commented Apr 18, 2016

Is this still valid?

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Apr 18, 2016

Member

not landing on 2.0 but useful to guide the Warnings API as the request is to get proper deprecation warning messages on the reporter, not only an exception pushing a failure, even if it's well handled by QUnit.

Member

leobalter commented Apr 18, 2016

not landing on 2.0 but useful to guide the Warnings API as the request is to get proper deprecation warning messages on the reporter, not only an exception pushing a failure, even if it's well handled by QUnit.

@trentmwillis trentmwillis removed this from the v2.0 milestone May 28, 2016

@trentmwillis

This comment has been minimized.

Show comment
Hide comment
@trentmwillis

trentmwillis Apr 9, 2017

Member

I'm going to close this. We added Logger.warn internally for logging deprecations.

Member

trentmwillis commented Apr 9, 2017

I'm going to close this. We added Logger.warn internally for logging deprecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment