New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUnit.equiv treats Map and Set as ordered #915

Closed
gibson042 opened this Issue Dec 31, 2015 · 1 comment

Comments

2 participants
@gibson042
Member

gibson042 commented Dec 31, 2015

https://jsfiddle.net/xd2jnbLa/

I think we should ignore insertion order when comparing these objects (along with WeakMap and WeakSet, which we ignore completely).

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Dec 31, 2015

Member

There is no way to discover the collections on WeekMaps and WeakSets, that's why it's ignored and compared as regular objects.

we should ignore insertion order

+1 to this.

Member

leobalter commented Dec 31, 2015

There is no way to discover the collections on WeekMaps and WeakSets, that's why it's ignored and compared as regular objects.

we should ignore insertion order

+1 to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment