Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Implement --require option #1271

Merged
merged 1 commit into from Mar 6, 2018

Conversation

5 participants
@trentmwillis
Copy link
Member

commented Mar 2, 2018

This PR implements a --require option for the CLI. It allows for any number of dependencies or files to be required prior to the test suite run actually starting.

Fixes #1222

@rwjblue

rwjblue approved these changes Mar 3, 2018

Copy link
Contributor

left a comment

Awesome! This is great, and unlocks some really nice patterns...

@trentmwillis trentmwillis merged commit c6365ed into qunitjs:master Mar 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@trentmwillis trentmwillis deleted the trentmwillis:require-flag branch Mar 6, 2018

@@ -0,0 +1,6 @@
const resolve = require( "resolve" );

This comment has been minimized.

Copy link
@Krinkle

Krinkle Mar 6, 2018

Member

Not related to this PR, but we seem to have grown a fair number of files in bin/ that are not intended as standalone CLI entry points. We should consider moving these to src/ instead.

This comment has been minimized.

Copy link
@trentmwillis

trentmwillis Mar 6, 2018

Author Member

👍 agreed, though I would like to ensure we keep some clear separation between CLI code and library code (just means we likely need src/cli or something)

@jdalton

This comment has been minimized.

Copy link

commented Mar 27, 2018

This is so cool! This should mean esm support can be enabled with qunit --require esm ❤️

Krinkle added a commit that referenced this pull request Dec 27, 2018

Krinkle added a commit that referenced this pull request Dec 27, 2018

trentmwillis added a commit that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.