Subsuite runner for Issue #128 #131

Closed
wants to merge 8 commits into
from

Conversation

2 participants
@wwalser
Contributor

wwalser commented Jul 28, 2011

Issue #128
An add-on for QUnit that allows multiple tests files to be run and results aggregated.

@wwalser

This comment has been minimized.

Show comment
Hide comment
@wwalser

wwalser Jul 30, 2011

Contributor

added tests

Contributor

wwalser commented Jul 30, 2011

added tests

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Aug 5, 2011

Member

I've created an addons folder for something else - can you rebase this and move it into addons/composite? Not that 'composite' is a perfect name, but subsuiteRunner also doesn't qualify for that.

Member

jzaefferer commented Aug 5, 2011

I've created an addons folder for something else - can you rebase this and move it into addons/composite? Not that 'composite' is a perfect name, but subsuiteRunner also doesn't qualify for that.

@wwalser

This comment has been minimized.

Show comment
Hide comment
@wwalser

wwalser Aug 5, 2011

Contributor

Can do. I agree that subsuiteRunner is a bit off as well.

Contributor

wwalser commented Aug 5, 2011

Can do. I agree that subsuiteRunner is a bit off as well.

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Aug 8, 2011

Member

This would break when embedded in an enviroment where QUnit.testStart gets overwritten. I guess we finally have a usecase where we need multiple subscribers for these events. We still don't have one for unsubscribing, so one way to solve this would be to turn registration from assining to a call: QUnit.testStart(function() { ... }). For compability we could check, when triggering, if that method was overwritten, then call it as we used to.

Member

jzaefferer commented Aug 8, 2011

This would break when embedded in an enviroment where QUnit.testStart gets overwritten. I guess we finally have a usecase where we need multiple subscribers for these events. We still don't have one for unsubscribing, so one way to solve this would be to turn registration from assining to a call: QUnit.testStart(function() { ... }). For compability we could check, when triggering, if that method was overwritten, then call it as we used to.

@wwalser

This comment has been minimized.

Show comment
Hide comment
@wwalser

wwalser Aug 9, 2011

Contributor

Callback registration is what I was thinking as well.

Thanks

(oops, didn't mean to close)

Contributor

wwalser commented Aug 9, 2011

Callback registration is what I was thinking as well.

Thanks

(oops, didn't mean to close)

@wwalser wwalser closed this Aug 9, 2011

@wwalser wwalser reopened this Aug 9, 2011

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Aug 9, 2011

Member

Another issue, more about addons in general: Should we prefix everything with "qunit-"? Or just those files intended for publish, e.g. those that could end up being copied to some other repository?

Apart from that it would make sense to rebase your branch to get rid of all the old commits. Likely requires a new pull request.

Member

jzaefferer commented Aug 9, 2011

Another issue, more about addons in general: Should we prefix everything with "qunit-"? Or just those files intended for publish, e.g. those that could end up being copied to some other repository?

Apart from that it would make sense to rebase your branch to get rid of all the old commits. Likely requires a new pull request.

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Aug 9, 2011

Member

Documented some ideas for better callbacks here: http://jquerytesting.pbworks.com/w/page/44122141/QUnit-Callbacks

Member

jzaefferer commented Aug 9, 2011

Documented some ideas for better callbacks here: http://jquerytesting.pbworks.com/w/page/44122141/QUnit-Callbacks

@wwalser

This comment has been minimized.

Show comment
Hide comment
@wwalser

wwalser Aug 15, 2011

Contributor

Pull request #143 has been created. I'll change the composite plugin to use the new callbacks once they have been created and pulled into upstream, until then I think it's in a reasonable state.

Contributor

wwalser commented Aug 15, 2011

Pull request #143 has been created. I'll change the composite plugin to use the new callbacks once they have been created and pulled into upstream, until then I think it's in a reasonable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment