qunit.css new look #188

Closed
wants to merge 2 commits into
from

4 participants

@friesencr

my friend gabe hendry http://www.gabehendry.com took a stab at a new style. I rather like the open minimalistic aproach to it.

@gabehendry

Thanks for the nod my friend!

@Krinkle
Member
Krinkle commented Dec 29, 2011

Hi,

Just a quick analysis of it code wise:

QUnit css should not style anything that is not contained within the #qunit- namespace due to often being embedded into other layouts. So styles for body or plain h1, h2 etc. must be removed.

Also selectors like h2#qunit-.. cover a problem. Why is the h2 selector required ? IDs must be unique.

@gabehendry

easy enough to change. the h2's were required for our purposes as we were doing some CSS for added elements in our own solution. I will strip them out and make a more contained CSS file.

@jzaefferer
Member

Thanks, landed this as an addon, along with the other alternative theme that lived in a branch for some time.

@gabehendry if you're still interested, another update against https://github.com/jquery/qunit/blob/master/addons/themes/gabe.css would be most welcome, to address the issues mentioned above.

@jzaefferer jzaefferer closed this Feb 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment