code around ie issues for location #384

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@clog
Contributor

clog commented Dec 25, 2012

Assigning incomplete url won't work for local files in ie7 and ie8. Means controls won't work when test page is opened locally.

code around ie issues for location
controls won't work in ie7, ie8
@@ -962,7 +962,8 @@ extend( QUnit, {
querystring += encodeURIComponent( key ) + "=" +
encodeURIComponent( params[ key ] ) + "&";
}
- return window.location.pathname + querystring.slice( 0, -1 );
+ return window.location.protocol + "//" + window.location.host +

This comment has been minimized.

@clog

clog Dec 26, 2012

Contributor

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

@clog

clog Dec 26, 2012

Contributor

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jan 3, 2013

Member

Thanks, landed in 8676feb

Member

jzaefferer commented Jan 3, 2013

Thanks, landed in 8676feb

@jzaefferer jzaefferer closed this Jan 3, 2013

@ghost ghost assigned jzaefferer Jan 3, 2013

leobalter added a commit to leobalter/qunit that referenced this pull request Mar 26, 2015

leobalter added a commit to leobalter/qunit that referenced this pull request Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment