New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert: Improve size and speed of QUnit.equiv #912

Closed
wants to merge 1 commit into
from

Conversation

3 participants
@gibson042
Member

gibson042 commented Dec 30, 2015

Inspired by gh-895 review. Inner comparisons are always QUnit.objectType-equal.

var prop = QUnit.objectType( a );
return callbacks[ prop ]( b, a );
var type = QUnit.objectType( a );
return QUnit.objectType( b ) === type && callbacks[ type ]( b, a );

This comment has been minimized.

@leobalter

leobalter Dec 30, 2015

Member

Until checking this change above, it is hard to see why the "nan" check is returning true only.

@leobalter

leobalter Dec 30, 2015

Member

Until checking this change above, it is hard to see why the "nan" check is returning true only.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Dec 30, 2015

Member

It looks good! I'm rerunning to check the tests results on different browsers.

Member

leobalter commented Dec 30, 2015

It looks good! I'm rerunning to check the tests results on different browsers.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Dec 30, 2015

Member

the new file has -36 lines from a previous file with 276 lines. This is great and - due to the code quality - a smart size cut.

Member

leobalter commented Dec 30, 2015

the new file has -36 lines from a previous file with 276 lines. This is great and - due to the code quality - a smart size cut.

@gibson042 gibson042 closed this in 5977d91 Dec 30, 2015

@leobalter leobalter removed the in progress label Dec 30, 2015

flore77 pushed a commit to flore77/qunit that referenced this pull request Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment