Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks for launch of Jekyll site #151

Closed
7 tasks done
trentmwillis opened this issue Apr 9, 2018 · 5 comments
Closed
7 tasks done

Tasks for launch of Jekyll site #151

trentmwillis opened this issue Apr 9, 2018 · 5 comments
Assignees
@Krinkle
Labels
Type: New content

Comments

@trentmwillis
Copy link
Member

trentmwillis commented Apr 9, 2018 •
edited by Krinkle

The following items still need to be addressed before launching:

  • Responsive/cross-browser styles (ensure the styles look good across most major browsers and viewport sizes)
    • Fix iframe on mobile
  • Accessibility (mainly for the nav, most others areas should be good)
    • Run axe-core audit on all the pages
  • Setup search (through Algolia which ESLint has been using)
  • Favicon
  • Point qunitjs.com domain to qunitjs.github.io
@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020 •
edited

Old homepage

https://qunitjs.com/

Kept:

  • "What is" tag line
  • Live HTML demo and CLI example.
  • Releases on CDN, npm, yarn, bower.
  • Changelog
  • Pre-release.
  • Link to API docs.

Changed:

  • Pre 2.4 blurp. – Moved to "Intro/Node" page, LGTM. (could also be removed perhaps, but fine for now)
  • Browser support. – Moved to "Intro/Node" page. LGTM.
  • Node.js LTS schedule. – Moved to "Intro/Browser" page. LGTM.
  • Link to plugins. – It is linked from the "Guides" menu, but could do with an inline link as well. Perhaps from the "Extensible" blurb. Anyway, not a blocker for launch. (To be continued at Promote plugins from the home page #100).
  • Link to Cookbook. – Removed, LGTM. (see below)
  • Link to examples (jQuery, jQuery UI, jQuery Validator plugin). – Removed, LGTM. Obsolete with new API docs site.
  • Community: jQuery Testing Forum. – Removed, LGTM. Was abandoned and obsoleted by our public Gitter channel.
  • Community: Chat on IRC. – Removed, LGTM. Was mostly for the team which we moved to a private Gitter channel.
  • Community: Twitter. – Moved to "About/Community" page, LGTM.
  • History. – Moved to "About/History" page. LGTM.

Old intro

https://qunitjs.com/intro/ / https://stage.qunitjs.com/intro/

  • LGTM

Pretty much entirely rewritten but I think that's okay. This has mostly been superseded over the years by our dedicated API docs at https://api.qunitjs.com/. If something comes up later due to a common question or mistake, we can always consider making adjustments later, but overall I like the much smaller and focussed intro page.

Old cookbook

https://qunitjs.com/cookbook/ / https://stage.qunitjs.com/cookbook/

Similar story as with the long intro page. Losing this seems fine for now.

  • Keep a redirect to /intro/?

Old about

https://qunitjs.com/about/ / https://stage.qunitjs.com/about/

  • Vision
  • Team

@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020 •
edited

I noticed the new site uses /page instead of /page/ and generates a 404 Not Found if using a trailing slash. We either need to keep redirects or configure Jekyll to use directory-style URLs instead.

For example: https://qunitjs.github.io/plugins/ vs https://qunitjs.github.io/plugins

  • Done.

@Krinkle Krinkle self-assigned this Jun 27, 2020
@Krinkle
Copy link
Member

Krinkle commented Jun 27, 2020 •
edited

Once these issues are addressed, I will:

@Krinkle Krinkle transferred this issue from qunitjs/qunitjs.github.io Jul 5, 2020
@Krinkle Krinkle changed the title Tasks for launch Tasks for launch of Jekyll site Jul 5, 2020
Krinkle added a commit to qunitjs/qunitjs.github.io that referenced this issue Jul 5, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
7685498 
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/qunitjs.github.io that referenced this issue Jul 5, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
b68ed2d 
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/qunitjs.github.io that referenced this issue Jul 5, 2020
@Krinkle
Add favicon file
b60328c 
Copied from https://github.com/jquery/jquery-wp-content/blob/v4.6.15/themes/qunitjs.com/i/favicon.ico

Ref qunitjs/qunitjs.com#151.
Krinkle pushed a commit that referenced this issue Jul 5, 2020
@trentmwillis @Krinkle
Initial commit of Jelyll website
2cdec49 
Ref #151.
Krinkle pushed a commit that referenced this issue Jul 5, 2020
@trentmwillis @Krinkle
Add Algolia search
cf89e2e 
Setup Travis to run algolia to index content for search.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
7a13042 
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Add favicon file
0c10e4c 
Copied from https://github.com/jquery/jquery-wp-content/blob/v4.6.15/themes/qunitjs.com/i/favicon.ico

Ref #151.
Krinkle pushed a commit that referenced this issue Jul 5, 2020
@trentmwillis @Krinkle
Add Algolia search
486c994 
Setup Travis to run algolia to index content for search.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
bc25f0c 
* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Use HTTPS for links where possible.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Add favicon file
bd95d7a 
Copied from https://github.com/jquery/jquery-wp-content/blob/v4.6.15/themes/qunitjs.com/i/favicon.ico

Ref #151.
@Krinkle Krinkle mentioned this issue Jul 5, 2020
Closed
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Minor color changes for headings/links
7eb58e6 
Avoid primary purple text color for text that isn't a link.

Ref #151 (comment)
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Add CNAME file
2653f42 
Ref #151.
Ref jquery/infrastructure#451.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
115bf53 
* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Preserve the /addons/ -> /plugins/ redirect from the  old site.

* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use HTTPS for links where possible.

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Add favicon file
5364e00 
Copied from https://github.com/jquery/jquery-wp-content/blob/v4.6.15/themes/qunitjs.com/i/favicon.ico

Ref #151.
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Minor color changes for headings/links
ae33a20 
Avoid primary purple text color for text that isn't a link.

Ref #151 (comment)
Krinkle added a commit that referenced this issue Jul 5, 2020
@Krinkle
Add CNAME file
cf7a3d0 
Ref #151.
Ref jquery/infrastructure#451.
@Krinkle Krinkle closed this as completed Jul 7, 2020
@Krinkle
Copy link
Member

Krinkle commented Jul 7, 2020 •
edited

... and we're live!

Old New
Old qunitjs dot com New quntjs dot com

Next, is to update the API site as see. Filed qunitjs/qunit#1458.

@Krinkle Krinkle mentioned this issue Jul 8, 2020
Closed
@Krinkle Krinkle mentioned this issue Jul 21, 2020
Closed
3 tasks
Krinkle pushed a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@trentmwillis @Krinkle
Add Algolia search
8c93ef0 
Setup Travis to run algolia to index content for search.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@Krinkle
Use 'title/' permalink and add /cookbook/ redirect
6f5af23 
* Use /:title/ instead of /:title for the permalinks so that it
  matches the old site for compatibility.

* Preserve the /addons/ -> /plugins/ redirect from the  old site.

* Add redirect for the <https://qunitjs.com/cookbook/> page
  we have on the old site to the new /intro page.

* Use HTTPS for links where possible.

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@Krinkle
Add favicon file
68927d6 
Copied from https://github.com/jquery/jquery-wp-content/blob/v4.6.15/themes/qunitjs.com/i/favicon.ico

Ref qunitjs/qunitjs.com#151.
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@Krinkle
Minor color changes for headings/links
8a5a9dc 
Avoid primary purple text color for text that isn't a link.

Ref qunitjs/qunitjs.com#151 (comment)
Krinkle added a commit to qunitjs/jekyll-theme-amethyst that referenced this issue Jul 26, 2020
@Krinkle
Add CNAME file
b74b4fe 
Ref qunitjs/qunitjs.com#151.
Ref jquery/infrastructure#451.
@trentmwillis
Copy link
Member Author

@Krinkle thank you so much for carrying this work over the finish line! Really happy to see this be live 💯 😄

Krinkle added a commit to jquery/jquery-wp-content that referenced this issue Aug 22, 2021
@Krinkle
All: Remove theme support for qunitjs.com and api.qunitjs.com
f594b19 
Keep a note of the blog_id because this will still exist on the
actual servers for a while and thus must not be re-used for something
else.

Ref qunitjs/qunitjs.com#151.
Ref jquery/infrastructure#456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

Labels
Type: New content
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Krinkle @trentmwillis