Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_tags() API is inconsistent #101

Closed
lazka opened this issue Jul 4, 2014 · 2 comments
Closed

add_tags() API is inconsistent #101

lazka opened this issue Jul 4, 2014 · 2 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From dus...@virtualroadside.com on December 07, 2011 05:21:13

All of the mutagen object types that support an 'add_tags()' function do so in the following way (mostly):

def add_tags(self):
    if self.tags:
        self.tags = Something()
    ... 

Whereas the MP4 add_tags function (line 670) always overwrites self.tags, regardless of whether there are pre-existing tags or not. This could cause external developers to accidentally overwrite existing tags in a file if they don't pay attention to this difference.

Original issue: http://code.google.com/p/mutagen/issues/detail?id=101


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 02, 2013 09:35:22

This issue was closed by revision 591f00fe3bcd .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on July 25, 2012 07:07:02

Status: Accepted

Attachment: mp4-add-tags-check-v1.patch

@lazka lazka closed this Apr 7, 2016
genodeftest added a commit to genodeftest/exaile that referenced this issue May 4, 2019
genodeftest added a commit to genodeftest/exaile that referenced this issue May 4, 2019
genodeftest added a commit to genodeftest/exaile that referenced this issue May 4, 2019
The issue referenced here has been closed a while ago. See
quodlibet/mutagen#101 and
quodlibet/mutagen@c1d3fb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.