Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutagen does not always close files (breaks when using pypy) #111

Closed
lazka opened this issue Jul 4, 2014 · 2 comments
Closed

mutagen does not always close files (breaks when using pypy) #111

lazka opened this issue Jul 4, 2014 · 2 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From marien.z...@gmail.com on June 02, 2012 13:24:39

A couple of tests fail when running the testsuite (using "setup.py test") with pypy 1.8. Two changes are necessary to get them to pass, both adding a missing f.close() call. (Files are closed when garbage-collected, and they are garbage-collected immediately after the last reference goes away in CPython but not in some other implementations like PyPy.)

I'm attaching a svn diff (against r108 ) that looks much more intimidating than it really is, as I'm adding a try/finally block, shifting a bunch of code one indentation level to the right. "svn diff -x -uw" after applying it is much more readable.

Attachment: mutagen-r108-close-files.patch

Original issue: http://code.google.com/p/mutagen/issues/detail?id=111


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on July 19, 2012 05:21:49

This issue was closed by revision r109 .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on July 19, 2012 03:56:23

Looks good
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.