Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4: container with 64-bit size containing zero should extend to end of file #132

Closed
lazka opened this issue Jul 4, 2014 · 2 comments
Closed
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From sidnei.d...@gmail.com on January 03, 2013 18:24:15

When a container has a '1' in the length field, indicating it has a 64-bit atom size, but then the atom size is set to zero, it should be treated as if there was a zero in the length field.

I'm not sure this is completely valid, as the sample file I found with this issue could not be read by either iTunes, Rhythmbox or VLC (because it only had an mdat container but no moov container). Perhaps this should raise an exception right away instead.

The failure to handle this case causes a problem similar to Issue #109 , as the atom length gets set to zero and mutagen keeps looping back to the same position on the file until a MemoryError happens.

Patch attached with test for the new behavior.

Attachment: 64-bit-length-zero.diff

Original issue: http://code.google.com/p/mutagen/issues/detail?id=132


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 04, 2013 07:00:02

This issue was closed by revision d3d0f5b668d7 .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 04, 2013 07:04:17

Sorry for the delay.

I went with the exception since I don't think they added magic values to two fields without really needing it.

If you find such a file which loads in iTunes, please report it.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.