Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyid3: Add tag mappings from MusicBrainz Picard #136

Open
lazka opened this issue Jul 4, 2014 · 8 comments
Open

easyid3: Add tag mappings from MusicBrainz Picard #136

lazka opened this issue Jul 4, 2014 · 8 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From freso.dk on March 14, 2013 21:32:39

MusicBrainz Picard supports a heap of tags that aren't currently supported by Mutagen. Importing these mappings from Picard to Mutagen would 1) allow users of Mutagen access to make tags in a file without writing custom mappings themselves, 2) allow Picard and possibly other projects to reduce their code extending Mutagen's features.

Compare e.g. https://github.com/musicbrainz/picard/blob/master/picard/formats/id3.py#L89 https://code.google.com/p/mutagen/source/browse/mutagen/easyid3.py#404

Original issue: http://code.google.com/p/mutagen/issues/detail?id=136


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on March 15, 2013 08:28:05

picard - easyid3 =

{'COMM': 'comment',
 'TCON': 'genre',
 'TDOR': 'originaldate',
 'TDRC': 'date',
 'TIT1': 'grouping',
 'TLAN': 'language',
 'WCOP': 'license',
 'WOAR': 'website'}

Status: Accepted

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 8, 2014

Original comment by Freso Fenderson (Bitbucket: Freso, GitHub: Freso):


For updated source links:
https://github.com/musicbrainz/picard/blob/master/picard/formats/id3.py#L100
https://bitbucket.org/lazka/mutagen/src/default/mutagen/easyid3.py#cl-441

  • note that there are plenty more than those listed in the previous comment by @lazka.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 19, 2014

Original comment by Ben Ockmore (Bitbucket: LordSputnik, GitHub: LordSputnik):


Ok, here's an updated list of tags which Picard supports and which aren't in the easyID3 interface:

'TIT1': 'grouping',
'TLAN': 'language',
'TDOR': 'originaldate',
'TSSE': 'encodersettings',
'WCOP': 'license',
'COMM': 'comment',


TXXX frames:

'MusicBrainz Release Track Id': 'musicbrainz_trackid',
'MusicBrainz Work Id': 'musicbrainz_workid',
'MusicBrainz Release Group Id': 'musicbrainz_releasegroupid',
'Acoustid Fingerprint': 'acoustid_fingerprint',
'Acoustid Id': 'acoustid_id',
'SCRIPT': 'script',
'LICENSE': 'license',
'CATALOGNUMBER': 'catalognumber',
'Artists': 'artists',
'Work': 'work',
'Writer': 'writer',

Out of these, we probably want to support at least TLAN, TDOR, COMM, "MusicBrainz Release Track Id", "MusicBrainz Work Id", "MusicBrainz Release Group Id", "Acoustid Fingerprint", "Acoustid Id" and "CATALOGNUMBER", so I'm going to go ahead and add those. Can add more if needed, or wait until they're included as part of the universal metadata format extension.

@Freso any other important ones in your opinion, that should be added straight away?

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 19, 2014

Original comment by Freso Fenderson (Bitbucket: Freso, GitHub: Freso):


Honestly, I'd like Mutagen to support all the ones Picard uses ASAP, both so that we can remove some code (eventually - we will still need to support older Mutagen versions for a while), but also to make it easier for other programs relying on Mutagen to use and manipulate information saved by Picard.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 19, 2014

Original comment by Ben Ockmore (Bitbucket: LordSputnik, GitHub: LordSputnik):


easyid3.py: added tag mappings from MusicBrainz Picard - see #136

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 19, 2014

Original comment by Ben Ockmore (Bitbucket: LordSputnik, GitHub: LordSputnik):


Some mappings have been added now - the following ones need a decision (and COMM needs some thinking about - tricky):

COMM
TIT1
TSSE
WCOP

"SCRIPT"
"LICENSE"
"Artists"
"Work"
"Writer"
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 13, 2015

Original comment by kama radski (Bitbucket: kamaradski, GitHub: kamaradski):


In order for one of my newer scripts to use the fanart.tv API, i would need to be able to read: 'MusicBrainz Release Group Id': 'musicbrainz_releasegroupid',

I can imagine there are more APIs\databases using exactly this tag. Any chance of this getting added soonish ?

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Oct 14, 2015

Original comment by Brad Lanam (Bitbucket: bll123, GitHub: bll123):


Here is more documentation that also shows the mapping to Vorbis/FLAC.

http://picard.musicbrainz.org/docs/mappings/

UFID is very important -- that's the musicbrainz recording id (confusingly called musicbrainz_trackid). See also issue #234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.