Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3 iTunes Podcast Tags #141

Closed
lazka opened this issue Jul 4, 2014 · 5 comments
Closed

ID3 iTunes Podcast Tags #141

lazka opened this issue Jul 4, 2014 · 5 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From dave.r...@gmail.com on April 12, 2013 22:03:27

Hi,

I've edited the id3.py file to include the ID3 tags iTunes uses to display a podcast's description, feed and identifier. These are:
TDES(TextFrame): "Description" # Podcast description
TGID(TextFrame): "Identifier" # Podcast identifier
WFED(UrlFrame): "Feed" # Podcast feed

Adding them was a simple matter of adding them as classes with the other tags (TIT2, TIT3, etc).

I'm a little unsure as to how to contribute to the project in terms of a patch etc., but hopefully this should make it easy enough for someone else to add the tags themselves if they so wish. (And any guidance on how to produce a patch for this would be great).

Original issue: http://code.google.com/p/mutagen/issues/detail?id=141


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From dave.r...@gmail.com on April 23, 2013 00:56:43

I've attempted to send you a file via email; I've attached it here also. The changes are on lines 1332, 1341 and 1393. (So I've not added the tags for ID3v2.2)

Those links are interesting. I didn't have to do anything but add these tags in as extra classes. I had already changed the files to being podcast types via iTunes, though I believe that's just another custom ID3 tag? I'm not sure why those other projects are attempting to make entirely new frames etc.

I'll attempt to make a patch this evening.

Sorry for the delay in sorting this out.

Attachment: id3.py

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 15, 2013 08:30:37

https://github.com/judwhite/IdSharp/pull/1 https://bitbucket.org/nicfit/eyed3/commits/cc06d3ce1d8714bf3c8fff9e4e6388bb2df3bc94 Do you have an example file (and can send it to me)?

To create a patch:

hg clone https://code.google.com/p/mutagen/ cd mutagen
# change stuff
./setup test # make sure all tests pass
hg diff > foobar.patch

Status: Accepted

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 23, 2013 01:30:12

I meant a mp3 file that contains the mentioned frames.

Does iTunes provide an interface to edit them?
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 05, 2013 13:39:23

This issue was closed by revision 16095505d66e .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From dave.r...@gmail.com on April 23, 2013 01:39:45

Ah! Sorry.

iTunes doesn't, strangely. It only displays the description and orders by the publication date (which you can't edit, but was in the mutagen id3.py file already). I initially used ID3 Editor to check/edit the tags until editing the id3.py file: http://www.pa-software.com/id3editor/ I've had to email you the podcast due to the 10mb attachment limit (the smallest one I have that I've edited via the script is 13mb).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.