Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAC support #15

Closed
lazka opened this issue Jul 4, 2014 · 8 comments
Closed

AAC support #15

lazka opened this issue Jul 4, 2014 · 8 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From joe.wreschnig@gmail.com on July 20, 2009 03:49:25

Add a file type for raw AAC / ADTS length parsing. frontend/main.c in the
FAAD2 source is a start for the format information.

Original issue: http://code.google.com/p/mutagen/issues/detail?id=15


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 03, 2013 09:18:49

Issue 133 has been merged into this issue.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 22, 2013 07:03:40

Status: Accepted

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


adts parser attached.

I'm not sure if we should rename it to AAC instead and parse ADIF/RAW as well. Input welcome.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Add ADTS/AAC file type. (Fixes issue #15)

  • Currently doesn't support ADIF
  • No tagging, but will skip id3v2
  • Will read the first 100 frames and guess the length/bitrate

Most aac files are ADTS, so closing the issue.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Philipp Wolfer (Bitbucket: phwolfer, GitHub: Unknown):


Is there actualy some tagging that is commonly used for ADTS files? MP3Tag seems to write Apev2 to those files (see http://forums.mp3tag.de/index.php?showtopic=11344), maybe this could also be supported in mutagen.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


I've found files with ID3v2/APEv2 and both at once. There is no official format as far as I know, but you can use the ID3/APEv2 classes to read/write tags for ADTS files.

I'd recommend putting them in an MP4 container:

gst-launch-1.0 filesrc location=a.aac ! aacparse ! mp4mux ! filesink location=a.mp4

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Philipp Wolfer (Bitbucket: phwolfer, GitHub: Unknown):


Ok, thanks for the info. I personally would use the MP4 container anyway, but I asked for MusicBrainz Picard, and there are people using ADTS for various reasons.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 24, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


My motivation for this was to allow identifying/loading those files in Quod Libet for playback only. I'll look into what other programs do with them.

@lazka lazka closed this Apr 7, 2016
lazka added a commit that referenced this issue Apr 7, 2016
* Currently doesn't support ADIF
* No tagging, but will skip id3v2
* Will read the first 100 frames and guess the length/bitrate

Most aac files are ADTS, so closing the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.