Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OggOpus: Support in-place rewrites for files with comment padding. #202

Closed
lazka opened this issue Nov 5, 2014 · 3 comments
Closed

OggOpus: Support in-place rewrites for files with comment padding. #202

lazka opened this issue Nov 5, 2014 · 3 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Nov 5, 2014

Originally reported by: Calvin Walton (Bitbucket: kepstin, GitHub: kepstin)


The current OggOpus draft specification defines support for including padding in the comments header field.

See https://tools.ietf.org/html/draft-ietf-codec-oggopus-06#section-5.2

To reproduce the relevant section here:

Immediately following the user comment list, the comment header MAY
contain zero-padding or other binary data which is not specified
here. If the least-significant bit of the first byte of this data is
1, then editors SHOULD preserve the contents of this data when
updating the tags, but if this bit is 0, all such data MAY be treated
as padding, and truncated or discarded as desired.


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 5, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


thanks

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Nov 25, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


oggopus: preserve vcomment padding if marked as non-padding. See issue #202

this was added in draft-5 of the oggopus spec

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Sep 6, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


This work now as of 39fa86b

@lazka lazka closed this Apr 7, 2016
lazka added a commit that referenced this issue Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.