Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ID3Warning #223

Closed
lazka opened this issue Apr 24, 2015 · 3 comments
Closed

Remove ID3Warning #223

lazka opened this issue Apr 24, 2015 · 3 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Apr 24, 2015

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


It just adds noise and afaics there is no way to hide a warning by default without global state.

beetbox/beets#1434


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented May 9, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Here is a file containing a non-synch-safe APIC frame

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented May 9, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


id3: Don't warn on leftover frame data. (Fixes issue #223)

Return the data in Frame._readData instead so we can still test it.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented May 9, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Other removals in 07c6484 and 14e8364

@lazka lazka added major bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
lazka added a commit that referenced this issue Apr 7, 2016
Return the data in Frame._readData instead so we can still test it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.