Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-id3.py traceback if no tags #227

Closed
lazka opened this issue Jul 7, 2015 · 2 comments
Closed

copy-id3.py traceback if no tags #227

lazka opened this issue Jul 7, 2015 · 2 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 7, 2015

Originally reported by: quite (Bitbucket: quite, GitHub: quite)


If a file doesn't have any tags, copy-id3.py barfs a traceback. Perhaps it would be nice to return 1 (or so) to the shell instead...

#!python

Traceback (most recent call last):
  File "/home/quite/bin/copy-id3.py", line 36, in <module>
    _main()
  File "/home/quite/bin/copy-id3.py", line 20, in _main
    copy_id3(args.srcname, args.destname, args.verbose)
  File "/home/quite/bin/copy-id3.py", line 29, in copy_id3
    dest.save()
  File "/usr/lib/python2.7/site-packages/mutagen/_file.py", line 114, in save
    raise ValueError("no tags in file")
ValueError: no tags in file

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Aug 18, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Don't raise on FileType.save() if there are no tags. Fixes #227

There is nothing wrong about doing nothing, raising just adds
another special case that needs to be handled by the user.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Aug 18, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Note that mutagen also contains a "mid3cp" tool for copying id3 tags.

@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
lazka added a commit that referenced this issue Apr 7, 2016
There is nothing wrong about doing nothing, raising just adds
another special case that needs to be handled by the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.