Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overeager deprecation warnings #261

Closed
sampsyo opened this issue Jun 29, 2016 · 1 comment
Closed

Overeager deprecation warnings #261

sampsyo opened this issue Jun 29, 2016 · 1 comment
Labels
bug

Comments

@sampsyo
Copy link
Contributor

@sampsyo sampsyo commented Jun 29, 2016

I noticed today while running the beets tests against Mutagen 1.33 that I started getting deprecation warnings like this:

/Users/asampson/Library/Python/2.7/lib/python/site-packages/mutagen/_file.py:138: DeprecationWarning: save(filename=...) is deprecated, reload the file
  DeprecationWarning)

but we don't use that deprecated filename= parameter. In fact, a really simple test script triggers the deprecation warning in master:

$ cat t.py
import mutagen
x = mutagen.File('x.m4a')
x.save()
$ python -W error t.py
Traceback (most recent call last):
  File "t.py", line 3, in <module>
    x.save()
  File "/Users/asampson/code/mutagen/mutagen/mp4/__init__.py", line 1014, in save
    super(MP4, self).save(*args, **kwargs)
  File "/Users/asampson/code/mutagen/mutagen/_util.py", line 98, in wrapper
    return func(self, h, *args, **kwargs)
  File "/Users/asampson/code/mutagen/mutagen/_file.py", line 138, in save
    DeprecationWarning)
DeprecationWarning: save(filename=...) is deprecated, reload the file

This isn't a big deal because users don't see this message, but nose's defaults happened to make it appear. But I thought you might like to know anyway.

@lazka lazka added the bug label Jun 29, 2016
@lazka

This comment has been minimized.

Copy link
Member

@lazka lazka commented Jun 29, 2016

Thanks

@lazka lazka closed this in 06668f6 Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.