Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3: POPM: Does not support empty counts as per ID3v2.4 spec. #33

Closed
lazka opened this issue Jul 4, 2014 · 4 comments
Closed

ID3: POPM: Does not support empty counts as per ID3v2.4 spec. #33

lazka opened this issue Jul 4, 2014 · 4 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From opensh...@gmail.com on October 27, 2009 17:21:58

http://www.id3.org/id3v2.4.0-frames Here's a fix:

class POPM(Frame):
    """Popularimeter.

    This frame keys a rating (out of 255) and a play count to an email
    address.

    Attributes:
    email -- email this POPM frame is for
    rating -- rating from 0 to 255
    count -- number of times the files has been played
    """
    _framespec = [Latin1TextSpec('email'), ByteSpec('rating')]
    _optionalspec = [ IntegerSpec('count') ]
    HashKey = property(lambda s: '%s:%s' % (s.FrameID, s.email))

    def __eq__(self, other): return self.rating == other
    def __pos__(self): return self.rating
    def _pprint(self):
        try: return "%s=%s %s/255" % (self.email, self.count, self.rating)
        except AttributeError: return "%s=%s %s/255" % (self.email, '0',
self.rating)

Original issue: http://code.google.com/p/mutagen/issues/detail?id=33


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From opensh...@gmail.com on October 27, 2009 09:25:56

Fixing this allows mutagen to read Windows Media Player rating tags. :) For now, this
will be monkey patched in MB Picard.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 27, 2009 12:58:59

Summary: ID3: POPM: Does not support empty counts as per ID3v2.4 spec.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 27, 2009 12:58:40

Status: Accepted
Labels: -Type-Enhancement -Priority-Low Type-Defect Priority-High

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 27, 2009 22:16:20

This issue was closed by revision r62 .

Status: Fixed
Mergedinto: -

@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.