Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4 stik & rtng bug #349

Closed
gotcha9999 opened this issue Jul 21, 2018 · 2 comments
Closed

MP4 stik & rtng bug #349

gotcha9999 opened this issue Jul 21, 2018 · 2 comments
Labels
bug

Comments

@gotcha9999
Copy link

@gotcha9999 gotcha9999 commented Jul 21, 2018

Writing of stik and rtng values doesn't work correctly.

Example:

You have a correct tagged MP4 audio file with stik = 1 (Normal) and rtng = 1 (Explicit) and the
output from AtomicParsley is
Atom "stik" contains: Normal
Atom "rtng" contains: Explicit Content

After saving this file with mutagen you have
Atom "stik" contains: 1
Atom "rtng" contains: 1

OK (from Mp3Tag):

00 00 00 19			Atom Length: 25
73 74 69 6B			Atom Name: "stik"
00 00 00 11			Atom Length: 17
64 61 74 61			Atom Name: "data"
00 00 00 15			Atom Version & Flags
00 00 00 00			4 Bytes Null Space
01				1 -> Normal/Music

Wrong length (using mutagen):

00 00 00 1A			Atom Length: _26_
73 74 69 6B			Atom Name: "stik"
00 00 00 12			Atom Length: _18_
64 61 74 61			Atom Name: "data"
00 00 00 15			Atom Version & Flags
00 00 00 00			4 Bytes Null Space
00 01				<- wrong!
@lazka

This comment has been minimized.

Copy link
Member

@lazka lazka commented Jul 26, 2018

confirmed, thanks

@lazka lazka added the bug label Jul 26, 2018
@lazka lazka closed this in 0ef6d64 Aug 10, 2018
lazka added a commit that referenced this issue Aug 10, 2018
mp4: fix 8bit ints getting saved as 16bit (rtng, stik, shwm). Fixes #349
@lazka

This comment has been minimized.

Copy link
Member

@lazka lazka commented Aug 11, 2018

A new release is out. Simply re-saving files with mutagen will fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.