Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to modify mid3v2 to write APIC frame (covert art) into media file. #47

Closed
lazka opened this issue Jul 4, 2014 · 5 comments
Closed
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From jon.uc...@gmail.com on December 30, 2009 03:09:50

Thanks in advance for considering this patch.

I've attached a patch to to mutagen-1.18.tar.gz that modifies the script
mid3v2 and the man page mid3v2.1.

The patch allows mid3v2 to add an APIC frame to a media file.

I did not modify the tests, because AFAIK there is no test for mid3v2.

I've tested the patched version of mid3v2 on a few dozen mp3 files and have
had no problems.

If there's something else I need to do to support this patch please let me
know.

Attachment: mutagen-1.18-patch-mid3v2.patch

Original issue: http://code.google.com/p/mutagen/issues/detail?id=47


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on January 08, 2010 15:16:16

Status: Accepted

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on January 06, 2010 11:33:55

If mid3v2 is going to support APIC, it should support more functionality - in
particular, it should be able to choose which APIC subkey to use, and be able to set
the description.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Feb 8, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


Issue #213 was marked as a duplicate of this issue.

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Aug 17, 2015

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


relevant: beetbox/beets#899 (comment)

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented May 11, 2016

@lazka lazka closed this in 0811beb Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.